From c0350dc362ce97af7424e8b7b93113a0a2e50510 Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Tue, 6 Oct 2020 17:17:45 +0200 Subject: [PATCH] DEV: replaces unecessary (action (mut .*)) by (mut .*) (#10822) --- .../javascripts/admin/addon/templates/badges-show.hbs | 8 ++++---- .../templates/components/admin-user-field-item.hbs | 2 +- .../addon/templates/components/embeddable-host.hbs | 2 +- .../addon/templates/components/permalink-form.hbs | 2 +- .../templates/components/screened-ip-address-form.hbs | 2 +- .../templates/components/site-settings/category.hbs | 2 +- .../addon/templates/components/site-settings/enum.hbs | 2 +- .../templates/modal/admin-color-scheme-select-base.hbs | 2 +- .../addon/templates/modal/admin-install-theme.hbs | 2 +- .../admin/addon/templates/search-logs-index.hbs | 4 ++-- .../admin/addon/templates/search-logs-term.hbs | 4 ++-- .../javascripts/admin/addon/templates/user-badges.hbs | 2 +- .../javascripts/admin/addon/templates/user-index.hbs | 6 +++--- .../admin/addon/templates/web-hooks-show.hbs | 4 ++-- .../discourse/app/templates/components/badge-title.hbs | 2 +- .../app/templates/components/edit-category-general.hbs | 2 +- .../templates/components/edit-category-settings.hbs | 6 +++--- .../app/templates/components/edit-category-tags.hbs | 2 +- .../app/templates/components/edit-topic-timer-form.hbs | 2 +- .../app/templates/components/group-flair-inputs.hbs | 2 +- .../templates/components/groups-form-email-fields.hbs | 2 +- .../components/groups-form-interaction-fields.hbs | 8 ++++---- .../components/groups-form-membership-fields.hbs | 2 +- .../app/templates/components/invite-link-panel.hbs | 2 +- .../app/templates/components/invite-panel.hbs | 2 +- .../app/templates/components/user-fields/dropdown.hbs | 2 +- .../javascripts/discourse/app/templates/composer.hbs | 4 ++-- .../discourse/app/templates/full-page-search.hbs | 8 ++++---- .../app/templates/group/manage/categories.hbs | 10 +++++----- .../discourse/app/templates/groups/index.hbs | 2 +- .../discourse/app/templates/mobile/users.hbs | 2 +- .../discourse/app/templates/modal/bookmark.hbs | 2 +- .../app/templates/modal/bulk-change-category.hbs | 2 +- .../app/templates/modal/convert-to-public-topic.hbs | 2 +- .../discourse/app/templates/modal/grant-badge.hbs | 2 +- .../discourse/app/templates/modal/move-to-topic.hbs | 2 +- .../discourse/app/templates/preferences/account.hbs | 2 +- .../discourse/app/templates/preferences/categories.hbs | 10 +++++----- .../discourse/app/templates/preferences/emails.hbs | 10 +++++----- .../discourse/app/templates/preferences/interface.hbs | 6 +++--- .../app/templates/preferences/notifications.hbs | 8 ++++---- .../discourse/app/templates/preferences/profile.hbs | 2 +- .../discourse/app/templates/review-index.hbs | 10 +++++----- .../discourse/app/templates/review-settings.hbs | 2 +- .../app/templates/user/notifications-index.hbs | 2 +- .../javascripts/discourse/app/templates/users.hbs | 2 +- .../wizard/templates/components/invite-list.hbs | 2 +- .../templates/components/wizard-field-dropdown.hbs | 2 +- .../components/discourse-local-dates-create-form.hbs | 6 +++--- .../discourse/templates/modal/poll-ui-builder.hbs | 8 ++++---- 50 files changed, 93 insertions(+), 93 deletions(-) diff --git a/app/assets/javascripts/admin/addon/templates/badges-show.hbs b/app/assets/javascripts/admin/addon/templates/badges-show.hbs index 49741c8bc66..1c88e9e4172 100644 --- a/app/assets/javascripts/admin/addon/templates/badges-show.hbs +++ b/app/assets/javascripts/admin/addon/templates/badges-show.hbs @@ -17,7 +17,7 @@ options=(hash maximum=1 ) - onChange=(action (mut buffered.icon)) + onChange=(fn (mut buffered.icon)) }}

{{i18n "admin.badges.icon_help"}}

@@ -35,7 +35,7 @@ name="badge_type_id" value=buffered.badge_type_id content=badgeTypes - onChange=(action (mut buffered.badge_type_id)) + onChange=(fn (mut buffered.badge_type_id)) isDisabled=readOnly }} @@ -50,7 +50,7 @@ content=badgeGroupings class="badge-selector" nameProperty="name" - onChange=(action (mut buffered.badge_grouping_id)) + onChange=(fn (mut buffered.badge_grouping_id)) }} {{d-button class="btn-default" @@ -112,7 +112,7 @@ name="trigger" value=buffered.trigger content=badgeTriggers - onChange=(action (mut buffered.trigger)) + onChange=(fn (mut buffered.trigger)) disabled=readOnly }} diff --git a/app/assets/javascripts/admin/addon/templates/components/admin-user-field-item.hbs b/app/assets/javascripts/admin/addon/templates/components/admin-user-field-item.hbs index 211cc00b516..7414446097b 100644 --- a/app/assets/javascripts/admin/addon/templates/components/admin-user-field-item.hbs +++ b/app/assets/javascripts/admin/addon/templates/components/admin-user-field-item.hbs @@ -3,7 +3,7 @@ {{combo-box content=fieldTypes value=buffered.field_type - onChange=(action (mut buffered.field_type)) + onChange=(fn (mut buffered.field_type)) }} {{/admin-form-row}} diff --git a/app/assets/javascripts/admin/addon/templates/components/embeddable-host.hbs b/app/assets/javascripts/admin/addon/templates/components/embeddable-host.hbs index 7d73d93a2b3..1ed3212d6ff 100644 --- a/app/assets/javascripts/admin/addon/templates/components/embeddable-host.hbs +++ b/app/assets/javascripts/admin/addon/templates/components/embeddable-host.hbs @@ -16,7 +16,7 @@ {{category-chooser value=categoryId class="small" - onChange=(action (mut categoryId)) + onChange=(mut categoryId) }} diff --git a/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs b/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs index 8792d78734c..f8ec83bfd2a 100644 --- a/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs +++ b/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs @@ -11,7 +11,7 @@ {{combo-box content=permalinkTypes value=permalinkType - onChange=(action (mut permalinkType)) + onChange=(mut permalinkType) class="permalink-type" }} diff --git a/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs b/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs index 488c14fb5ff..aa9da28f0c1 100644 --- a/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs +++ b/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs @@ -4,7 +4,7 @@ {{combo-box content=actionNames value=actionName - onChange=(action (mut actionName)) + onChange=(mut actionName) }} {{d-button class="btn-default" action=(action "submit") disabled=formSubmitted label="admin.logs.screened_ips.form.add"}} diff --git a/app/assets/javascripts/admin/addon/templates/components/site-settings/category.hbs b/app/assets/javascripts/admin/addon/templates/components/site-settings/category.hbs index 80a793834ea..089e590256d 100644 --- a/app/assets/javascripts/admin/addon/templates/components/site-settings/category.hbs +++ b/app/assets/javascripts/admin/addon/templates/components/site-settings/category.hbs @@ -1,7 +1,7 @@ {{category-chooser value=value allowUncategorized=true - onChange=(action (mut value)) + onChange=(mut value) }} {{setting-validation-message message=validationMessage}}
{{html-safe setting.description}}
diff --git a/app/assets/javascripts/admin/addon/templates/components/site-settings/enum.hbs b/app/assets/javascripts/admin/addon/templates/components/site-settings/enum.hbs index 265301db6a4..be5f5cc7464 100644 --- a/app/assets/javascripts/admin/addon/templates/components/site-settings/enum.hbs +++ b/app/assets/javascripts/admin/addon/templates/components/site-settings/enum.hbs @@ -1,7 +1,7 @@ {{combo-box content=setting.validValues value=value - onChange=(action (mut value)) + onChange=(mut value) valueProperty=setting.computedValueProperty nameProperty=setting.computedNameProperty options=(hash diff --git a/app/assets/javascripts/admin/addon/templates/modal/admin-color-scheme-select-base.hbs b/app/assets/javascripts/admin/addon/templates/modal/admin-color-scheme-select-base.hbs index 15a39314cd3..0d18c2656e4 100644 --- a/app/assets/javascripts/admin/addon/templates/modal/admin-color-scheme-select-base.hbs +++ b/app/assets/javascripts/admin/addon/templates/modal/admin-color-scheme-select-base.hbs @@ -4,7 +4,7 @@ {{combo-box content=model value=selectedBaseThemeId - onChange=(action (mut selectedBaseThemeId)) + onChange=(mut selectedBaseThemeId) valueProperty="base_scheme_id" }} {{/d-modal-body}} diff --git a/app/assets/javascripts/admin/addon/templates/modal/admin-install-theme.hbs b/app/assets/javascripts/admin/addon/templates/modal/admin-install-theme.hbs index 053ce042a8c..d0c607b7f5c 100644 --- a/app/assets/javascripts/admin/addon/templates/modal/admin-install-theme.hbs +++ b/app/assets/javascripts/admin/addon/templates/modal/admin-install-theme.hbs @@ -93,7 +93,7 @@ valueProperty="value" content=createTypes value=selectedType - onChange=(action (mut selectedType)) + onChange=(mut selectedType) }} {{/if}} diff --git a/app/assets/javascripts/admin/addon/templates/search-logs-index.hbs b/app/assets/javascripts/admin/addon/templates/search-logs-index.hbs index baf516489d8..aafdf2aab9b 100644 --- a/app/assets/javascripts/admin/addon/templates/search-logs-index.hbs +++ b/app/assets/javascripts/admin/addon/templates/search-logs-index.hbs @@ -1,10 +1,10 @@
- {{period-chooser period=period onChange=(action (mut period))}} + {{period-chooser period=period onChange=(mut period)}} {{combo-box content=searchTypeOptions value=searchType class="search-logs-filter" - onChange=(action (mut searchType)) + onChange=(mut searchType) }}
diff --git a/app/assets/javascripts/admin/addon/templates/search-logs-term.hbs b/app/assets/javascripts/admin/addon/templates/search-logs-term.hbs index b4b0c8aed3e..43753b1e39a 100644 --- a/app/assets/javascripts/admin/addon/templates/search-logs-term.hbs +++ b/app/assets/javascripts/admin/addon/templates/search-logs-term.hbs @@ -1,10 +1,10 @@
- {{period-chooser period=period onChange=(action (mut period))}} + {{period-chooser period=period onChange=(mut period)}} {{combo-box content=searchTypeOptions value=searchType class="search-logs-filter" - onChange=(action (mut searchType)) + onChange=(mut searchType) }}
diff --git a/app/assets/javascripts/admin/addon/templates/user-badges.hbs b/app/assets/javascripts/admin/addon/templates/user-badges.hbs index a5e66640d3c..ecf30a1b867 100644 --- a/app/assets/javascripts/admin/addon/templates/user-badges.hbs +++ b/app/assets/javascripts/admin/addon/templates/user-badges.hbs @@ -20,7 +20,7 @@ filterable=true value=selectedBadgeId content=grantableBadges - onChange=(action (mut selectedBadgeId)) + onChange=(mut selectedBadgeId) }}
diff --git a/app/assets/javascripts/admin/addon/templates/user-index.hbs b/app/assets/javascripts/admin/addon/templates/user-index.hbs index c043ce529f1..31f979a753f 100644 --- a/app/assets/javascripts/admin/addon/templates/user-index.hbs +++ b/app/assets/javascripts/admin/addon/templates/user-index.hbs @@ -371,7 +371,7 @@ content=site.trustLevels nameProperty="detailedName" value=model.trustLevel.id - onChange=(action (mut model.trust_level)) + onChange=(mut model.trust_level) }} {{#if model.dirty}} @@ -537,7 +537,7 @@ content=availableGroups value=customGroupIdsBuffer labelProperty="name" - onChange=(action (mut customGroupIdsBuffer)) + onChange=(fn (mut customGroupIdsBuffer)) }}
{{#if customGroupsDirty}} @@ -555,7 +555,7 @@ content=model.customGroups value=model.primary_group_id none="admin.groups.no_primary" - onChange=(action (mut model.primary_group_id)) + onChange=(mut model.primary_group_id) }} {{#if primaryGroupDirty}} diff --git a/app/assets/javascripts/admin/addon/templates/web-hooks-show.hbs b/app/assets/javascripts/admin/addon/templates/web-hooks-show.hbs index 83540a03da4..1c7e97beb37 100644 --- a/app/assets/javascripts/admin/addon/templates/web-hooks-show.hbs +++ b/app/assets/javascripts/admin/addon/templates/web-hooks-show.hbs @@ -18,7 +18,7 @@ content=contentTypes name="content-type" value=model.content_type - onChange=(action (mut model.content_type)) + onChange=(mut model.content_type) }} @@ -53,7 +53,7 @@ {{category-selector categories=model.categories - onChange=(action (mut model.categories)) + onChange=(mut model.categories) }}
{{i18n "admin.web_hooks.categories_filter_instructions"}}
diff --git a/app/assets/javascripts/discourse/app/templates/components/badge-title.hbs b/app/assets/javascripts/discourse/app/templates/components/badge-title.hbs index de1e7fbafac..81b1dc7a8e7 100644 --- a/app/assets/javascripts/discourse/app/templates/components/badge-title.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/badge-title.hbs @@ -13,7 +13,7 @@ value=selectedUserBadgeId nameProperty="badge.name" content=selectableUserBadges - onChange=(action (mut selectedUserBadgeId)) + onChange=(fn (mut selectedUserBadgeId)) }} diff --git a/app/assets/javascripts/discourse/app/templates/components/edit-category-general.hbs b/app/assets/javascripts/discourse/app/templates/components/edit-category-general.hbs index 23e2981f000..05ff39de9fe 100644 --- a/app/assets/javascripts/discourse/app/templates/components/edit-category-general.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/edit-category-general.hbs @@ -19,7 +19,7 @@ allowSubCategories=true allowUncategorized=false allowRestrictedCategories=true - onChange=(action (mut category.parent_category_id)) + onChange=(fn (mut category.parent_category_id)) }} {{/if}} diff --git a/app/assets/javascripts/discourse/app/templates/components/edit-category-settings.hbs b/app/assets/javascripts/discourse/app/templates/components/edit-category-settings.hbs index f847963bfcf..c8cda21a940 100644 --- a/app/assets/javascripts/discourse/app/templates/components/edit-category-settings.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/edit-category-settings.hbs @@ -38,7 +38,7 @@ id="category-search-priority" content=searchPrioritiesOptions value=category.search_priority - onChange=(action (mut category.search_priority)) + onChange=(mut category.search_priority) options=(hash placementStrategy="absolute" ) @@ -190,7 +190,7 @@ options=(hash none="category.sort_options.default" ) - onChange=(action (mut category.sort_order)) + onChange=(mut category.sort_order) }} {{#unless isDefaultSortOrder}} {{combo-box @@ -201,7 +201,7 @@ none="category.sort_options.default" placementStrategy="absolute" ) - onChange=(action (mut category.sort_ascending)) + onChange=(mut category.sort_ascending) }} {{/unless}} diff --git a/app/assets/javascripts/discourse/app/templates/components/edit-category-tags.hbs b/app/assets/javascripts/discourse/app/templates/components/edit-category-tags.hbs index 6fcb4bded0b..405b1448512 100644 --- a/app/assets/javascripts/discourse/app/templates/components/edit-category-tags.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/edit-category-tags.hbs @@ -6,7 +6,7 @@ everyTag=true excludeSynonyms=true unlimitedTagCount=true - onChange=(action (mut category.allowed_tags)) + onChange=(mut category.allowed_tags) options=(hash filterPlaceholder="category.tags_placeholder" ) diff --git a/app/assets/javascripts/discourse/app/templates/components/edit-topic-timer-form.hbs b/app/assets/javascripts/discourse/app/templates/components/edit-topic-timer-form.hbs index 0303a494a62..a5a50503cd6 100644 --- a/app/assets/javascripts/discourse/app/templates/components/edit-topic-timer-form.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/edit-topic-timer-form.hbs @@ -13,7 +13,7 @@ {{category-chooser value=topicTimer.category_id excludeCategoryId=excludeCategoryId - onChange=(action (mut topicTimer.category_id)) + onChange=(fn (mut topicTimer.category_id)) }} {{/if}} diff --git a/app/assets/javascripts/discourse/app/templates/components/group-flair-inputs.hbs b/app/assets/javascripts/discourse/app/templates/components/group-flair-inputs.hbs index f198b7bb636..6203f330086 100644 --- a/app/assets/javascripts/discourse/app/templates/components/group-flair-inputs.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/group-flair-inputs.hbs @@ -18,7 +18,7 @@ name="icon" value=model.flair_icon options=(hash maximum=1) - onChange=(action (mut model.flair_icon)) + onChange=(mut model.flair_icon) }} {{else if flairPreviewImage}} {{image-uploader diff --git a/app/assets/javascripts/discourse/app/templates/components/groups-form-email-fields.hbs b/app/assets/javascripts/discourse/app/templates/components/groups-form-email-fields.hbs index 555282097f0..6a4a49b905d 100644 --- a/app/assets/javascripts/discourse/app/templates/components/groups-form-email-fields.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/groups-form-email-fields.hbs @@ -63,7 +63,7 @@ valueProperty="value" content=mailboxes none="groups.manage.email.mailboxes.disabled" - onChange=(action (mut model.imap_mailbox_name))}} + onChange=(mut model.imap_mailbox_name)}} {{else}} {{i18n "groups.manage.email.mailboxes.none_found"}} {{/if}} diff --git a/app/assets/javascripts/discourse/app/templates/components/groups-form-interaction-fields.hbs b/app/assets/javascripts/discourse/app/templates/components/groups-form-interaction-fields.hbs index 80d0b147547..0ba572897a7 100644 --- a/app/assets/javascripts/discourse/app/templates/components/groups-form-interaction-fields.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/groups-form-interaction-fields.hbs @@ -10,7 +10,7 @@ content=visibilityLevelOptions castInteger=true class="groups-form-visibility-level" - onChange=(action (mut model.visibility_level)) + onChange=(mut model.visibility_level) }}
@@ -26,7 +26,7 @@ value=membersVisibilityLevel content=visibilityLevelOptions class="groups-form-members-visibility-level" - onChange=(action (mut model.members_visibility_level)) + onChange=(mut model.members_visibility_level) }}
@@ -45,7 +45,7 @@ value=mentionableLevel content=aliasLevelOptions class="groups-form-mentionable-level" - onChange=(action (mut model.mentionable_level)) + onChange=(mut model.mentionable_level) }}
@@ -58,7 +58,7 @@ value=messageableLevel content=aliasLevelOptions class="groups-form-messageable-level" - onChange=(action (mut model.messageable_level)) + onChange=(mut model.messageable_level) }}
diff --git a/app/assets/javascripts/discourse/app/templates/components/groups-form-membership-fields.hbs b/app/assets/javascripts/discourse/app/templates/components/groups-form-membership-fields.hbs index 03a6813bf2c..09a5180845b 100644 --- a/app/assets/javascripts/discourse/app/templates/components/groups-form-membership-fields.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/groups-form-membership-fields.hbs @@ -32,7 +32,7 @@ value=groupTrustLevel content=trustLevelOptions class="groups-form-grant-trust-level" - onChange=(action (mut model.grant_trust_level)) + onChange=(mut model.grant_trust_level) }}