github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-29 00:00:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Include resolved locale in anonymous cache key (#10289)

Browse Source 
This only applies when set_locale_from_accept_language_header is enabled
This commit is contained in:
David Taylor
2020-07-22 18:00:07 +01:00
committed by GitHub
parent bcb0e62363
commit c09b5807f3
5 changed files with 52 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
spec/components/middleware/anonymous_cache_spec.rb
View File

@ -46,6 +46,32 @@ describe Middleware::AnonymousCache::Helper do
end
end
context "with header-based locale locale" do
it "handles different languages" do
# Normally does not check the language header
french1 = new_helper("HTTP_ACCEPT_LANGUAGE" => "fr").cache_key
french2 = new_helper("HTTP_ACCEPT_LANGUAGE" => "FR").cache_key
english = new_helper("HTTP_ACCEPT_LANGUAGE" => SiteSetting.default_locale).cache_key
none = new_helper.cache_key
expect(none).to eq(french1)
expect(none).to eq(french2)
expect(none).to eq(english)
SiteSetting.allow_user_locale = true
SiteSetting.set_locale_from_accept_language_header = true
french1 = new_helper("HTTP_ACCEPT_LANGUAGE" => "fr").cache_key
french2 = new_helper("HTTP_ACCEPT_LANGUAGE" => "FR").cache_key
english = new_helper("HTTP_ACCEPT_LANGUAGE" => SiteSetting.default_locale).cache_key
none = new_helper.cache_key
expect(none).to eq(english)
expect(french1).to eq(french2)
expect(french1).not_to eq(none)
end
end
context 'force_anonymous!' do
before do
RateLimiter.enable