From c0c236f36eaf27243049502ecb612ed109f44db9 Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Thu, 11 Apr 2019 16:36:47 -0400 Subject: [PATCH] FIX: Better to put a ReviewableUser back into pending than silently fail --- app/jobs/regular/create_user_reviewable.rb | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/jobs/regular/create_user_reviewable.rb b/app/jobs/regular/create_user_reviewable.rb index 07ddb22582e..8d06f9474ae 100644 --- a/app/jobs/regular/create_user_reviewable.rb +++ b/app/jobs/regular/create_user_reviewable.rb @@ -11,7 +11,7 @@ class Jobs::CreateUserReviewable < Jobs::Base if user = User.find_by(id: args[:user_id]) return if user.approved? - reviewable = ReviewableUser.create!( + reviewable = ReviewableUser.needs_review!( target: user, created_by: Discourse.system_user, reviewable_by_moderator: true, @@ -28,8 +28,5 @@ class Jobs::CreateUserReviewable < Jobs::Base force_review: true ) end - - rescue ActiveRecord::RecordNotUnique - # If the reviewable is somehow queued twice, we can ignore. end end