github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 11:11:13 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

PERF: Optimize uploads:disable_secure_uploads to load in batches (#31030)

Browse Source 
This commit updates the `uploads:disable_secure_uploads` to be more
memory efficient by loading records in batches instead.
This commit is contained in:
Alan Guo Xiang Tan
2025-01-28 15:31:00 +08:00
committed by GitHub
parent ed316b40a4
commit c0fdb2f33d
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
lib/tasks/uploads.rake
View File

@ -574,23 +574,29 @@ task "uploads:disable_secure_uploads" => :environment do
.joins(:upload_references) .joins(:upload_references)
.where(upload_references: { target_type: "Post" }) .where(upload_references: { target_type: "Post" })
.where(secure: true) .where(secure: true)
secure_upload_count = secure_uploads.count secure_upload_count = secure_uploads.count
secure_upload_ids = secure_uploads.pluck(:id)
puts "", "Marking #{secure_upload_count} uploads as not secure.", "" puts "", "Marking #{secure_upload_count} uploads as not secure.", ""
secure_uploads.update_all(
secure: false,
security_last_changed_at: Time.zone.now,
security_last_changed_reason: "marked as not secure by disable_secure_uploads task",
)
post_ids_to_rebake = secure_uploads.in_batches do |relation|
DB.query_single( secure_upload_ids = relation.pluck(:id)
"SELECT DISTINCT target_id FROM upload_references WHERE upload_id IN (?) AND target_type = 'Post'",
secure_upload_ids, relation.update_all(
secure: false,
security_last_changed_at: Time.zone.now,
security_last_changed_reason: "marked as not secure by disable_secure_uploads task",
) )
adjust_acls(secure_upload_ids)
mark_upload_posts_for_rebake(post_ids_to_rebake) post_ids_to_rebake =
DB.query_single(
"SELECT DISTINCT target_id FROM upload_references WHERE upload_id IN (?) AND target_type = 'Post'",
secure_upload_ids,
)
adjust_acls(secure_upload_ids)
mark_upload_posts_for_rebake(post_ids_to_rebake)
end
puts "", "Rebaking and uploading complete!", "" puts "", "Rebaking and uploading complete!", ""
end end