FIX: Reviewables should not be created for users until they are active

Conversely, if a user is deactivated the reviewable should automatically
be rejected.

Before this fix, if a user was not active they'd still show in the
review queue but without an "Approve" button which was confusing.
This commit is contained in:
Robin Ward
2019-04-03 12:04:05 -04:00
parent 974007a3cc
commit c1ea63bdc1
13 changed files with 82 additions and 17 deletions

View File

@ -290,6 +290,9 @@ describe WebHook do
Fabricate(:user_web_hook, active: true)
user
user.activate
Jobs::CreateUserReviewable.new.execute(user_id: user.id)
job_args = Jobs::EmitWebHookEvent.jobs.last["args"].first
expect(job_args["event_name"]).to eq("user_created")