From c4644c61d97c823b7dd940ffaf0967a104f4b58c Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Tue, 14 Apr 2020 08:18:49 +0200 Subject: [PATCH] DEV: enforces double quotes ember-template-lint (#9416) --- .template-lintrc.js | 2 +- .../javascripts/admin/templates/admin.hbs | 26 +++---- .../admin/templates/api-keys-index.hbs | 8 +- .../admin/templates/api-keys-new.hbs | 6 +- .../admin/templates/api-keys-show.hbs | 12 +-- .../javascripts/admin/templates/api.hbs | 4 +- .../javascripts/admin/templates/backups.hbs | 6 +- .../admin/templates/badges-award.hbs | 22 +++--- .../admin/templates/badges-index.hbs | 2 +- .../admin/templates/badges-show.hbs | 48 ++++++------ .../javascripts/admin/templates/badges.hbs | 14 ++-- .../admin/templates/components/ace-editor.hbs | 2 +- .../components/admin-editable-field.hbs | 8 +- .../templates/components/admin-form-row.hbs | 4 +- .../admin/templates/components/admin-nav.hbs | 2 +- .../components/admin-report-storage-stats.hbs | 2 +- .../components/admin-report-table.hbs | 6 +- .../admin-report-trust-level-counts.hbs | 10 +-- .../templates/components/admin-report.hbs | 4 +- .../components/admin-theme-editor.hbs | 30 ++++---- .../components/dashboard-problems.hbs | 4 +- .../components/email-styles-editor.hbs | 18 ++--- .../templates/components/embeddable-host.hbs | 2 +- .../components/embedding-setting.hbs | 2 +- .../templates/components/flag-user-lists.hbs | 14 ++-- .../admin/templates/components/flag-user.hbs | 14 ++-- .../components/inline-edit-checkbox.hbs | 2 +- .../components/install-theme-item.hbs | 4 +- .../components/penalty-post-action.hbs | 8 +- .../templates/components/resumable-upload.hbs | 4 +- .../components/screened-ip-address-form.hbs | 2 +- .../components/setting-validation-message.hbs | 2 +- .../templates/components/silence-details.hbs | 8 +- .../site-customization-change-details.hbs | 2 +- .../site-customization-change-field.hbs | 2 +- .../templates/components/site-setting.hbs | 6 +- .../site-settings/category-list.hbs | 2 +- .../components/site-settings/category.hbs | 2 +- .../components/site-settings/compact-list.hbs | 2 +- .../components/site-settings/enum.hbs | 2 +- .../components/site-settings/group-list.hbs | 2 +- .../components/site-settings/host-list.hbs | 2 +- .../components/site-settings/list.hbs | 2 +- .../components/site-settings/secret-list.hbs | 2 +- .../components/site-settings/string.hbs | 2 +- .../components/site-settings/tag-list.hbs | 2 +- .../components/site-settings/upload.hbs | 2 +- .../site-settings/uploaded-image-list.hbs | 2 +- .../components/site-settings/url-list.hbs | 2 +- .../components/site-settings/value-list.hbs | 2 +- .../components/site-text-summary.hbs | 8 +- .../components/suspension-details.hbs | 10 +-- .../templates/components/tags-uploader.hbs | 6 +- .../templates/components/themes-list-item.hbs | 2 +- .../templates/components/themes-list.hbs | 4 +- .../admin/templates/components/value-list.hbs | 4 +- .../components/watched-word-form.hbs | 2 +- .../components/watched-word-uploader.hbs | 6 +- .../templates/customize-colors-index.hbs | 2 +- .../admin/templates/customize-colors-show.hbs | 14 ++-- .../templates/customize-email-style-edit.hbs | 6 +- .../admin/templates/customize-email-style.hbs | 6 +- .../customize-email-templates-edit.hbs | 4 +- .../admin/templates/customize-themes-edit.hbs | 22 +++--- .../admin/templates/customize-themes-show.hbs | 32 ++++---- .../javascripts/admin/templates/customize.hbs | 18 ++--- .../admin/templates/dashboard_general.hbs | 10 +-- .../admin/templates/dashboard_moderation.hbs | 2 +- .../admin/templates/dashboard_reports.hbs | 2 +- .../admin/templates/email-advanced-test.hbs | 10 +-- .../admin/templates/email-bounced.hbs | 20 ++--- .../admin/templates/email-index.hbs | 14 ++-- .../admin/templates/email-preview-digest.hbs | 30 ++++---- .../admin/templates/email-received.hbs | 16 ++-- .../admin/templates/email-rejected.hbs | 20 ++--- .../admin/templates/email-sent.hbs | 28 +++---- .../admin/templates/email-skipped.hbs | 22 +++--- .../javascripts/admin/templates/email.hbs | 18 ++--- .../javascripts/admin/templates/embedding.hbs | 22 +++--- .../javascripts/admin/templates/emojis.hbs | 4 +- .../javascripts/admin/templates/logs.hbs | 14 ++-- .../admin/templates/logs/screened-emails.hbs | 24 +++--- .../admin/templates/logs/screened-urls.hbs | 22 +++--- .../templates/logs/staff-action-logs.hbs | 40 +++++----- .../templates/modal/admin-add-upload.hbs | 10 +-- .../templates/modal/admin-install-theme.hbs | 30 ++++---- .../templates/modal/admin-silence-user.hbs | 2 +- .../templates/modal/admin-suspend-user.hbs | 4 +- .../templates/modal/admin-theme-item.hbs | 2 +- .../modal/site-setting-default-categories.hbs | 4 +- .../admin/templates/permalinks.hbs | 12 +-- .../javascripts/admin/templates/plugins.hbs | 6 +- .../admin/templates/search-logs-index.hbs | 16 ++-- .../admin/templates/search-logs-term.hbs | 22 +++--- .../templates/site-settings-category.hbs | 4 +- .../admin/templates/site-settings.hbs | 10 +-- .../admin/templates/site-text-edit.hbs | 10 +-- .../admin/templates/site-text-index.hbs | 6 +- .../javascripts/admin/templates/site-text.hbs | 2 +- .../admin/templates/user-badges.hbs | 34 ++++----- .../admin/templates/user-fields.hbs | 6 +- .../admin/templates/user-index.hbs | 4 +- .../admin/templates/user-tl3-requirements.hbs | 66 ++++++++--------- .../admin/templates/users-list-show.hbs | 34 ++++----- .../admin/templates/users-list.hbs | 16 ++-- .../admin/templates/watched-words-action.hbs | 4 +- .../admin/templates/watched-words.hbs | 6 +- .../admin/templates/web-hooks-show-events.hbs | 30 ++++---- .../admin/templates/web-hooks-show.hbs | 52 ++++++------- .../javascripts/admin/templates/web-hooks.hbs | 32 ++++---- .../javascripts/discourse/templates/about.hbs | 74 +++++++++---------- .../discourse/templates/account-created.hbs | 4 +- .../templates/account-created/edit-email.hbs | 4 +- .../templates/account-created/index.hbs | 2 +- .../templates/account-created/resent.hbs | 6 +- .../discourse/templates/badges/index.hbs | 10 +-- .../discourse/templates/badges/show.hbs | 24 +++--- .../templates/components/avatar-uploader.hbs | 8 +- .../templates/components/backup-uploader.hbs | 2 +- .../templates/components/badge-card.hbs | 16 ++-- .../templates/components/badge-selector.hbs | 2 +- .../templates/components/badge-title.hbs | 6 +- .../templates/components/basic-topic-list.hbs | 6 +- .../components/bulk-select-button.hbs | 2 +- .../templates/components/cancel-link.hbs | 2 +- .../categories-and-latest-topics.hbs | 4 +- .../components/categories-and-top-topics.hbs | 4 +- .../components/categories-boxes-topic.hbs | 2 +- .../categories-boxes-with-topics.hbs | 10 +-- .../templates/components/categories-boxes.hbs | 19 +++-- .../templates/components/categories-only.hbs | 22 +++--- .../components/categories-topic-list.hbs | 6 +- .../components/category-name-fields.hbs | 6 +- .../components/category-title-link.hbs | 2 +- .../templates/components/category-unread.hbs | 4 +- .../templates/components/choose-message.hbs | 12 +-- .../templates/components/choose-topic.hbs | 12 +-- .../templates/components/color-picker.hbs | 2 +- .../components/composer-user-selector.hbs | 8 +- .../components/create-topics-notice.hbs | 4 +- .../templates/components/csv-uploader.hbs | 2 +- .../templates/components/d-button.hbs | 2 +- .../templates/components/d-editor.hbs | 10 +-- .../templates/components/d-modal-cancel.hbs | 2 +- .../templates/components/d-modal.hbs | 2 +- .../components/date-time-input-range.hbs | 4 +- .../desktop-notification-config.hbs | 2 +- .../templates/components/directory-item.hbs | 2 +- .../components/edit-category-general.hbs | 34 ++++----- .../components/edit-category-images.hbs | 8 +- .../components/edit-category-security.hbs | 8 +- .../components/edit-category-settings.hbs | 56 +++++++------- .../components/edit-category-tab.hbs | 2 +- .../components/edit-category-tags.hbs | 34 ++++----- .../edit-category-topic-template.hbs | 2 +- .../components/edit-topic-timer-form.hbs | 2 +- .../templates/components/emoji-picker.hbs | 4 +- .../templates/components/emoji-uploader.hbs | 2 +- .../templates/components/featured-topic.hbs | 6 +- .../templates/components/flag-action-type.hbs | 20 ++--- .../templates/components/flag-selection.hbs | 2 +- .../components/generated-invite-link.hbs | 2 +- .../templates/components/google-search.hbs | 6 +- .../components/group-activity-filter.hbs | 4 +- .../components/group-card-contents.hbs | 12 +-- .../components/group-flair-inputs.hbs | 18 ++--- .../components/group-manage-logs-row.hbs | 10 +-- .../components/group-manage-save-button.hbs | 6 +- .../templates/components/group-member.hbs | 2 +- .../templates/components/group-navigation.hbs | 4 +- .../templates/components/group-post.hbs | 14 ++-- .../templates/components/group-selector.hbs | 2 +- .../groups-form-interaction-fields.hbs | 26 +++---- .../groups-form-membership-fields.hbs | 22 +++--- .../components/groups-form-profile-fields.hbs | 12 +-- .../templates/components/groups-info.hbs | 4 +- .../components/ignored-user-list.hbs | 6 +- .../templates/components/image-uploader.hbs | 4 +- .../templates/components/images-uploader.hbs | 2 +- .../templates/components/ip-lookup.hbs | 2 +- .../components/latest-topic-list-item.hbs | 10 +-- .../components/mobile-category-topic.hbs | 6 +- .../templates/components/popup-input-tip.hbs | 2 +- .../components/preference-checkbox.hbs | 2 +- .../templates/components/quote-button.hbs | 2 +- .../components/reviewable-claimed-topic.hbs | 6 +- .../reviewable-conversation-post.hbs | 4 +- .../components/reviewable-created-by-name.hbs | 2 +- .../components/reviewable-created-by.hbs | 2 +- .../components/reviewable-field-text.hbs | 2 +- .../templates/components/reviewable-field.hbs | 4 +- .../components/reviewable-flagged-post.hbs | 14 ++-- .../components/reviewable-histories.hbs | 2 +- .../templates/components/reviewable-item.hbs | 38 +++++----- .../components/reviewable-post-header.hbs | 6 +- .../components/reviewable-queued-post.hbs | 16 ++-- .../templates/components/reviewable-score.hbs | 18 ++--- .../components/reviewable-scores.hbs | 2 +- .../components/reviewable-topic-link.hbs | 6 +- .../templates/components/reviewable-user.hbs | 28 +++---- .../templates/components/save-controls.hbs | 2 +- .../templates/components/score-value.hbs | 8 +- .../components/search-advanced-options.hbs | 4 +- .../components/security-key-form.hbs | 4 +- .../components/shared-draft-controls.hbs | 6 +- .../templates/components/tag-groups-form.hbs | 14 ++-- .../templates/components/tag-info.hbs | 6 +- .../templates/components/tag-list.hbs | 4 +- .../templates/components/topic-entrance.hbs | 4 +- .../components/topic-footer-buttons.hbs | 2 +- .../components/topic-post-badges.hbs | 6 +- .../templates/components/topic-progress.hbs | 8 +- .../templates/components/topic-status.hbs | 20 ++--- .../components/user-card-contents.hbs | 34 ++++----- .../components/user-fields/confirm.hbs | 10 +-- .../components/user-fields/dropdown.hbs | 8 +- .../templates/components/user-fields/text.hbs | 8 +- .../components/user-flag-percentage.hbs | 2 +- .../templates/components/user-info.hbs | 4 +- .../components/user-profile-avatar.hbs | 4 +- .../templates/components/user-stat.hbs | 4 +- .../templates/components/user-stream-item.hbs | 26 +++---- .../user-summary-category-search.hbs | 2 +- .../components/user-summary-section.hbs | 2 +- .../components/user-summary-topic.hbs | 4 +- .../discourse/templates/composer.hbs | 50 ++++++------- .../templates/composer/custom-body.hbs | 2 +- .../templates/composer/education.hbs | 2 +- .../templates/composer/group-mentioned.hbs | 2 +- .../templates/composer/similar-topics.hbs | 6 +- .../discourse/templates/discovery/topics.hbs | 14 ++-- .../discourse/templates/email-login.hbs | 2 +- .../discourse/templates/exception.hbs | 2 +- .../discourse/templates/full-page-search.hbs | 34 ++++----- .../discourse/templates/group-index.hbs | 16 ++-- .../discourse/templates/group-requests.hbs | 8 +- .../javascripts/discourse/templates/group.hbs | 14 ++-- .../discourse/templates/group/activity.hbs | 4 +- .../discourse/templates/group/manage.hbs | 4 +- .../discourse/templates/group/manage/logs.hbs | 10 +-- .../discourse/templates/group/messages.hbs | 10 +-- .../discourse/templates/groups/index.hbs | 14 ++-- .../discourse/templates/groups/new.hbs | 10 +-- .../discourse/templates/invites/show.hbs | 24 +++--- .../discourse/templates/login-preferences.hbs | 4 +- .../mobile/components/basic-topic-list.hbs | 24 +++--- .../mobile/components/categories-only.hbs | 24 +++--- .../mobile/components/mobile-nav.hbs | 4 +- .../mobile/components/navigation-bar.hbs | 6 +- .../templates/mobile/discovery/topics.hbs | 12 +-- .../templates/mobile/modal/login.hbs | 12 +-- .../discourse/templates/mobile/users.hbs | 12 +-- .../templates/modal/activation-resent.hbs | 2 +- .../modal/associate-account-confirm.hbs | 2 +- .../discourse/templates/modal/auth-token.hbs | 8 +- .../templates/modal/avatar-selector.hbs | 10 +-- .../discourse/templates/modal/bookmark.hbs | 4 +- .../templates/modal/bulk-actions-buttons.hbs | 2 +- .../modal/bulk-notification-level.hbs | 6 +- .../templates/modal/change-owner.hbs | 4 +- .../templates/modal/change-timestamp.hbs | 6 +- .../modal/convert-to-public-topic.hbs | 4 +- .../templates/modal/create-account.hbs | 26 +++---- .../templates/modal/edit-topic-timer.hbs | 10 +-- .../templates/modal/explain-reviewable.hbs | 10 +-- .../modal/feature-topic-on-profile.hbs | 2 +- .../templates/modal/forgot-password.hbs | 4 +- .../discourse/templates/modal/grant-badge.hbs | 4 +- .../templates/modal/group-bulk-add.hbs | 2 +- .../discourse/templates/modal/history.hbs | 8 +- .../templates/modal/jump-to-post.hbs | 6 +- .../discourse/templates/modal/login.hbs | 16 ++-- .../templates/modal/move-to-topic.hbs | 54 +++++++------- .../templates/modal/not-activated.hbs | 2 +- .../templates/modal/publish-page.hbs | 4 +- .../discourse/templates/modal/raw-email.hbs | 8 +- .../templates/modal/reorder-categories.hbs | 4 +- .../modal/request-group-membership-form.hbs | 2 +- .../modal/second-factor-add-security-key.hbs | 6 +- .../modal/second-factor-add-totp.hbs | 14 ++-- .../modal/second-factor-edit-security-key.hbs | 4 +- .../templates/modal/second-factor-edit.hbs | 4 +- .../discourse/templates/modal/tag-upload.hbs | 2 +- .../templates/modal/topic-bulk-actions.hbs | 2 +- .../templates/modal/upload-selector.hbs | 10 +-- .../templates/navigation/category.hbs | 4 +- .../discourse/templates/password-reset.hbs | 16 ++-- .../discourse/templates/preferences-email.hbs | 18 ++--- .../templates/preferences-second-factor.hbs | 20 ++--- .../templates/preferences-username.hbs | 12 +-- .../discourse/templates/preferences.hbs | 58 +++++++-------- .../templates/preferences/account.hbs | 58 +++++++-------- .../discourse/templates/preferences/apps.hbs | 2 +- .../templates/preferences/categories.hbs | 26 +++---- .../templates/preferences/emails.hbs | 34 ++++----- .../templates/preferences/interface.hbs | 18 ++--- .../templates/preferences/notifications.hbs | 16 ++-- .../templates/preferences/profile.hbs | 30 ++++---- .../discourse/templates/preferences/tags.hbs | 18 ++--- .../discourse/templates/preferences/users.hbs | 8 +- .../discourse/templates/review-index.hbs | 30 ++++---- .../discourse/templates/review-settings.hbs | 16 ++-- .../discourse/templates/review-topics.hbs | 6 +- .../discourse/templates/review.hbs | 6 +- .../discourse/templates/static.hbs | 2 +- .../discourse/templates/tag-groups-index.hbs | 2 +- .../discourse/templates/tag-groups.hbs | 2 +- .../discourse/templates/tags/index.hbs | 6 +- .../discourse/templates/tags/show.hbs | 8 +- .../javascripts/discourse/templates/topic.hbs | 32 ++++---- .../discourse/templates/unknown.hbs | 2 +- .../discourse/templates/user-invited-show.hbs | 50 ++++++------- .../templates/user-private-messages-tags.hbs | 6 +- .../javascripts/discourse/templates/user.hbs | 42 +++++------ .../discourse/templates/user/activity.hbs | 22 +++--- .../discourse/templates/user/bookmarks.hbs | 2 +- .../discourse/templates/user/messages.hbs | 32 ++++---- .../templates/user/notifications-index.hbs | 6 +- .../templates/user/notifications.hbs | 32 ++++---- .../templates/user/profile-hidden.hbs | 2 +- .../discourse/templates/user/stream.hbs | 2 +- .../discourse/templates/user/summary.hbs | 32 ++++---- .../javascripts/discourse/templates/users.hbs | 12 +-- .../multi-select/selected-category.hbs | 2 +- .../wizard/templates/application.hbs | 8 +- .../templates/components/invite-list-user.hbs | 4 +- .../templates/components/invite-list.hbs | 2 +- .../templates/components/radio-button.hbs | 8 +- .../templates/components/staff-count.hbs | 2 +- .../components/wizard-field-image.hbs | 2 +- .../templates/components/wizard-field.hbs | 8 +- .../templates/components/wizard-step.hbs | 28 +++---- 332 files changed, 1788 insertions(+), 1789 deletions(-) diff --git a/.template-lintrc.js b/.template-lintrc.js index b4d322875e0..1150803258f 100644 --- a/.template-lintrc.js +++ b/.template-lintrc.js @@ -43,7 +43,7 @@ module.exports = { "no-unnecessary-concat": true, "no-unnecessary-component-helper": true, "no-unused-block-params": true, - "quotes": false, + quotes: "double", "require-button-type": false, "require-iframe-title": true, "require-valid-alt-text": false, diff --git a/app/assets/javascripts/admin/templates/admin.hbs b/app/assets/javascripts/admin/templates/admin.hbs index dacf526c53d..bcbe6940d4f 100644 --- a/app/assets/javascripts/admin/templates/admin.hbs +++ b/app/assets/javascripts/admin/templates/admin.hbs @@ -3,35 +3,35 @@
-
-
+
+
{{outlet}}
diff --git a/app/assets/javascripts/admin/templates/api-keys-index.hbs b/app/assets/javascripts/admin/templates/api-keys-index.hbs index 0672b99f4fe..ac5dbf7c6ba 100644 --- a/app/assets/javascripts/admin/templates/api-keys-index.hbs +++ b/app/assets/javascripts/admin/templates/api-keys-index.hbs @@ -18,14 +18,14 @@ {{#each model as |k|}} - {{#if k.revoked_at}}{{d-icon 'times-circle'}}{{/if}} + {{#if k.revoked_at}}{{d-icon "times-circle"}}{{/if}} {{k.truncatedKey}} {{k.shortDescription}} -
{{i18n 'admin.api.user'}}
+
{{i18n "admin.api.user"}}
{{#if k.user}} {{#link-to "adminUser" k.user}} {{avatar k.user imageSize="small"}} @@ -35,11 +35,11 @@ {{/if}} -
{{i18n 'admin.api.created'}}
+
{{i18n "admin.api.created"}}
{{format-date k.created_at}} -
{{i18n 'admin.api.last_used'}}
+
{{i18n "admin.api.last_used"}}
{{#if k.last_used_at}} {{format-date k.last_used_at}} {{else}} diff --git a/app/assets/javascripts/admin/templates/api-keys-new.hbs b/app/assets/javascripts/admin/templates/api-keys-new.hbs index 3dac84dae29..d48da805e51 100644 --- a/app/assets/javascripts/admin/templates/api-keys-new.hbs +++ b/app/assets/javascripts/admin/templates/api-keys-new.hbs @@ -1,6 +1,6 @@ -{{#link-to 'adminApiKeys.index' class="go-back"}} - {{d-icon 'arrow-left'}} - {{i18n 'admin.api.all_api_keys'}} +{{#link-to "adminApiKeys.index" class="go-back"}} + {{d-icon "arrow-left"}} + {{i18n "admin.api.all_api_keys"}} {{/link-to}}
diff --git a/app/assets/javascripts/admin/templates/api-keys-show.hbs b/app/assets/javascripts/admin/templates/api-keys-show.hbs index 736a4ef777c..d1d35da0175 100644 --- a/app/assets/javascripts/admin/templates/api-keys-show.hbs +++ b/app/assets/javascripts/admin/templates/api-keys-show.hbs @@ -1,11 +1,11 @@ -{{#link-to 'adminApiKeys.index' class="go-back"}} - {{d-icon 'arrow-left'}} - {{i18n 'admin.api.all_api_keys'}} +{{#link-to "adminApiKeys.index" class="go-back"}} + {{d-icon "arrow-left"}} + {{i18n "admin.api.all_api_keys"}} {{/link-to}}
{{#admin-form-row label="admin.api.key"}} - {{#if model.revoked_at}}{{d-icon 'times-circle'}}{{/if}} + {{#if model.revoked_at}}{{d-icon "times-circle"}}{{/if}} {{model.truncatedKey}} {{/admin-form-row}} @@ -18,7 +18,7 @@ {{/if}} -
+
{{#if editingDescription}} {{d-button class="ok" action=(action "saveDescription") icon="check"}} {{d-button class="cancel" action=(action "editDescription") icon="times"}} @@ -58,7 +58,7 @@ {{#if model.revoked_at}} {{format-date model.revoked_at leaveAgo="true"}} {{/if}} -
+
{{#if model.revoked_at}} {{d-button action=(action "undoRevokeKey") diff --git a/app/assets/javascripts/admin/templates/api.hbs b/app/assets/javascripts/admin/templates/api.hbs index 45bfbd9ca7d..288bbc71fe8 100644 --- a/app/assets/javascripts/admin/templates/api.hbs +++ b/app/assets/javascripts/admin/templates/api.hbs @@ -1,6 +1,6 @@ {{#admin-nav}} - {{nav-item route='adminApiKeys' label='admin.api.title'}} - {{nav-item route='adminWebHooks' label='admin.web_hooks.title'}} + {{nav-item route="adminApiKeys" label="admin.api.title"}} + {{nav-item route="adminWebHooks" label="admin.web_hooks.title"}} {{/admin-nav}}
diff --git a/app/assets/javascripts/admin/templates/backups.hbs b/app/assets/javascripts/admin/templates/backups.hbs index c8d72599e8d..23fb6dc4585 100644 --- a/app/assets/javascripts/admin/templates/backups.hbs +++ b/app/assets/javascripts/admin/templates/backups.hbs @@ -1,9 +1,9 @@ -
+