From c4de8565eceeadda8f2a800226a02d0c40752ae6 Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Mon, 11 Nov 2024 17:23:19 +0900 Subject: [PATCH] FIX: flakey due to 0 width/height images (#29700) https://github.com/mainmatter/qunit-dom/blob/master/API.md#isvisible will return true if offsetWidth or offsetHeight are zero which could happen in this case as the test could run before the image has loaded. By forcing a minimum height in the test we ensure it will be consistent. --- .../javascripts/components/chat-message-collapser-test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/chat/test/javascripts/components/chat-message-collapser-test.js b/plugins/chat/test/javascripts/components/chat-message-collapser-test.js index 91a77fba4b6..ac6e8fe2034 100644 --- a/plugins/chat/test/javascripts/components/chat-message-collapser-test.js +++ b/plugins/chat/test/javascripts/components/chat-message-collapser-test.js @@ -13,9 +13,9 @@ const youtubeCooked = const animatedImageCooked = "

written text

" + - '

' + + '

' + "

more written text

" + - '

' + + '

' + "

and even more

"; const externalImageCooked =