SECURITY: disable user entered badge SQL by default

- Hidden site settings now must be change via rails console
This commit is contained in:
Sam
2016-07-28 09:03:00 +10:00
parent cb3afd11b4
commit c6dbaca0dc
6 changed files with 110 additions and 41 deletions

View File

@ -46,6 +46,13 @@ describe Admin::SiteSettingsController do
xhr :put, :update, id: 'test_setting', test_setting: 'hello'
end
it 'does not allow changing of hidden settings' do
SiteSetting.setting(:hidden_setting, "hidden", hidden: true)
result = xhr :put, :update, id: 'hidden_setting', hidden_setting: 'not allowed'
expect(SiteSetting.hidden_setting).to eq("hidden")
expect(result.status).to eq(422)
end
it 'fails when a setting does not exist' do
expect {
xhr :put, :update, id: 'provider', provider: 'gotcha'