github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-24 06:44:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Move setting deprecation check to SiteSetting::Update service (#31993)

Browse Source 
This PR moves the logic that checks if a site setting we're trying to update has been deprecated from one of the controllers into a policy of the SiteSetting::Update service.

It also gives us the opportunity to shift the error message into a locale file.
This commit is contained in:
Ted Johansson
2025-03-26 15:56:18 +08:00
committed by GitHub
parent 525406ad20
commit c8ccd4da31
7 changed files with 91 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/controllers/admin/site_settings_controller.rb
View File

@ -21,25 +21,10 @@ class Admin::SiteSettingsController < Admin::AdminController
params.require(:id)
id = params[:id]
update_existing_users = params[:update_existing_user].present?
value = params[id]
new_setting_name =
SiteSettings::DeprecatedSettings::SETTINGS.find do |old_name, new_name, override, _|
if old_name == id
if !override
raise Discourse::InvalidParameters,
"You cannot change this site setting because it is deprecated, use #{new_name} instead."
end
break new_name
end
end
id = new_setting_name if new_setting_name
previous_value = value_or_default(SiteSetting.get(id)) if update_existing_users
SiteSetting::Update.call(params: { settings: { id => value } }, guardian:) do
SiteSetting::Update.call(params: { settings: { id => params[id] } }, guardian:) do
on_success do |params:|
if update_existing_users
params.settings.to_a.each do |setting_name, setting_value|
@ -48,6 +33,9 @@ class Admin::SiteSettingsController < Admin::AdminController
end
render body: nil
end
on_failed_policy(:settings_are_not_deprecated) do |policy|
raise Discourse::InvalidParameters, policy.reason
end
on_failed_policy(:settings_are_visible) do |policy|
raise Discourse::InvalidParameters, policy.reason
end