DEV: Automatically require 'rails_helper' in all specs (#16077)

It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.

By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.
This commit is contained in:
David Taylor
2022-03-01 17:50:50 +00:00
committed by GitHub
parent 9415ec91a1
commit c9dab6fd08
815 changed files with 1 additions and 1487 deletions

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe "Local Dates" do
before do
freeze_time DateTime.parse('2018-11-10 12:00')

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
def generate_html(text, opts = {})
output = "<p><span"
output += " data-date=\"#{opts[:date]}\"" if opts[:date]

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe Post do
before do

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe DiscourseNarrativeBot::AdvancedUserNarrative do
fab!(:narrative_bot) { ::DiscourseNarrativeBot::Base.new }
fab!(:discobot_user) { narrative_bot.discobot_user }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe DiscourseNarrativeBot::NewUserNarrative do
fab!(:welcome_topic) { Fabricate(:topic, title: 'Welcome to Discourse') }
fab!(:narrative_bot) { ::DiscourseNarrativeBot::Base.new }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe DiscourseNarrativeBot::Store do
describe '.set' do
it 'should set the right value in the plugin store' do

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe DiscourseNarrativeBot::TrackSelector do
let(:user) { Fabricate(:user) }
let(:narrative_bot) { ::DiscourseNarrativeBot::Base.new }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Jobs::DiscourseNarrativeBot::GrantBadges do
let(:user) { Fabricate(:user) }
let(:other_user) { Fabricate(:user) }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe Jobs::DiscourseNarrativeBot::RemapOldBotImages do
context "when bot's post contains an old link" do
let!(:post) do

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Jobs::SendDefaultWelcomeMessage do
let(:user) { Fabricate(:user) }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe DiscourseNarrativeBot::CertificateGenerator do
let(:user) { Fabricate(:user) }
let(:avatar_url) { 'http://test.localhost/cdn/avatar.png' }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe "Discobot Certificate" do
let(:user) { Fabricate(:user, name: 'Jeff Atwood') }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe "Discobot welcome post" do
let(:user) { Fabricate(:user) }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe User do
let(:user) { Fabricate(:user) }
let(:profile_page_url) { "#{Discourse.base_url}/users/#{user.username}" }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe "discourse-presence" do
describe 'PresenceChannel configuration' do
fab!(:user) { Fabricate(:user) }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe DiscoursePoll::Poll do
fab!(:user) { Fabricate(:user) }
fab!(:user_2) { Fabricate(:user) }

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe DiscoursePoll::PollsUpdater do
def update(post, polls)

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe PrettyText do
def n(html)

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe ::DiscoursePoll::Poll do
describe ".transform_for_user_field_override" do
it "Transforms UserField name if a matching CustomUserField is present" do

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
def serialize_option(option, user)
PollOptionSerializer.new(
option,

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe 'SiteSetting.styleguide_admin_only' do
before do
SiteSetting.styleguide_enabled = true

View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
require 'rails_helper'
describe 'Styleguide assets' do
before do
SiteSetting.styleguide_enabled = true