DEV: Automatically require 'rails_helper' in all specs (#16077)

It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.

By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.

spec/lib/validators/allowed_ip_address_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe AllowedIpAddressValidator do
 
   let(:record) { Fabricate.build(:user, trust_level: TrustLevel[0], ip_address: '99.232.23.123') }

spec/lib/validators/category_search_priority_weights_validator_spec.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
 require 'validators/category_search_priority_weights_validator'
 
 RSpec.describe CategorySearchPriorityWeightsValidator do

spec/lib/validators/censored_words_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe CensoredWordsValidator do
   let(:value) { 'some new bad text' }
   let(:record) { Fabricate(:post, raw: 'this is a test') }

spec/lib/validators/css_color_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe CssColorValidator do
   subject { described_class.new }
 

spec/lib/validators/email_address_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe EmailAddressValidator do
   it 'should match valid emails' do
     ['test@discourse.org', 'good_user@discourse.org', 'incoming+%{reply_key}@discourse.org'].each do |email|

spec/lib/validators/email_setting_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe EmailSettingValidator do
   describe '#valid_value?' do
     subject(:validator) { described_class.new }

spec/lib/validators/email_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe EmailValidator do
   def blocks?(email)
     user = Fabricate.build(:user, email: email)

spec/lib/validators/enable_invite_only_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 RSpec.describe EnableInviteOnlyValidator do
   subject { described_class.new }
 

spec/lib/validators/enable_local_logins_via_email_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 RSpec.describe EnableLocalLoginsViaEmailValidator do
   subject { described_class.new }
 

spec/lib/validators/enable_sso_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 RSpec.describe EnableSsoValidator do
   subject { described_class.new }
 

spec/lib/validators/external_system_avatars_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe ExternalSystemAvatarsValidator do
   subject { described_class.new }
 

spec/lib/validators/group_setting_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe GroupSettingValidator do
   describe '#valid_value?' do
     subject(:validator) { described_class.new }

spec/lib/validators/host_list_setting_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe HostListSettingValidator do
   subject(:validator) { described_class.new() }
 

spec/lib/validators/integer_setting_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe IntegerSettingValidator do
   describe '#valid_value?' do
 

spec/lib/validators/ip_address_format_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe IpAddressFormatValidator do
 
   let(:record) { Fabricate.build(:screened_ip_address, ip_address: '99.232.23.123') }

spec/lib/validators/max_emojis_validator_spec.rb

@@ -1,7 +1,6 @@
 # encoding: UTF-8
 # frozen_string_literal: true
 
-require 'rails_helper'
 require 'validators/max_emojis_validator'
 
 describe MaxEmojisValidator do

spec/lib/validators/max_username_length_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe MaxUsernameLengthValidator do
   it "checks for minimum range" do
     SiteSetting.min_username_length = 6

spec/lib/validators/min_username_length_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe MinUsernameLengthValidator do
   it "checks for maximum range" do
     SiteSetting.max_username_length = 10

spec/lib/validators/password_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe PasswordValidator do
 
   def password_error_message(key)

spec/lib/validators/post_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe PostValidator do
   fab!(:topic) { Fabricate(:topic) }
   let(:post) { build(:post, topic: topic) }

spec/lib/validators/quality_title_validator_spec.rb

@@ -1,7 +1,6 @@
 # encoding: UTF-8
 # frozen_string_literal: true
 
-require 'rails_helper'
 require 'validators/quality_title_validator'
 require 'ostruct'
 

spec/lib/validators/regex_presence_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "rails_helper"
-
 RSpec.describe RegexPresenceValidator do
   subject { described_class.new(regex: 'latest', regex_error: 'site_settings.errors.must_include_latest') }
 

spec/lib/validators/regex_setting_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe RegexSettingValidator do
   describe '#valid_value?' do
     subject(:validator) { described_class.new }

spec/lib/validators/reply_by_email_address_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe ReplyByEmailAddressValidator do
 
   describe '#valid_value?' do

spec/lib/validators/reply_by_email_enabled_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe ReplyByEmailEnabledValidator do
 
   describe '#valid_value?' do

spec/lib/validators/search_tokenize_chinese_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe SearchTokenizeChineseValidator do
   it 'does not allow search_tokenize_chinese to be enabled when search_tokenize_japanese is enabled' do
     SiteSetting.search_tokenize_japanese = true

spec/lib/validators/search_tokenize_japanese_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe SearchTokenizeJapaneseValidator do
   it 'does not allow search_tokenize_japanese to be enabled when search_tokenize_chinese is enabled' do
     SiteSetting.search_tokenize_chinese = true

spec/lib/validators/selectable_avatars_mode_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe SelectableAvatarsModeValidator do
   describe '#valid_value?' do
     subject(:validator) { described_class.new }

spec/lib/validators/sso_overrides_email_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 RSpec.describe SsoOverridesEmailValidator do
   subject { described_class.new }
 

spec/lib/validators/string_setting_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe StringSettingValidator do
 
   describe '#valid_value?' do

spec/lib/validators/timezone_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe TimezoneValidator do
   describe "#valid?" do
     context "when timezone is ok" do

spec/lib/validators/topic_title_length_validator_spec.rb

@@ -1,7 +1,6 @@
 # encoding: UTF-8
 # frozen_string_literal: true
 
-require 'rails_helper'
 require 'validators/topic_title_length_validator'
 
 describe TopicTitleLengthValidator do

spec/lib/validators/unicode_username_allowlist_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe UnicodeUsernameAllowlistValidator do
   subject { described_class.new }
 

spec/lib/validators/unicode_username_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe UnicodeUsernameValidator do
   subject { described_class.new }
 

spec/lib/validators/upload_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe UploadValidator do
   subject(:validator) { described_class.new }
 

spec/lib/validators/url_validator_spec.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
 require 'validators/topic_title_length_validator'
 
 RSpec.describe UrlValidator do

spec/lib/validators/user_full_name_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "rails_helper"
-
 describe UserFullNameValidator do
   let(:validator) { described_class.new(attributes: :name) }
   subject(:validate) { validator.validate_each(record, :name, @name) }

spec/lib/validators/username_setting_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'rails_helper'
-
 describe UsernameSettingValidator do
   describe '#valid_value?' do
     subject(:validator) { described_class.new }