github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 16:34:31 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: SSO code should respect IP address filters

Browse Source
This commit is contained in:
Robin Ward
2015-02-23 15:58:45 -05:00
parent d63aed69f7
commit ca5730018a
6 changed files with 33 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/models/discourse_single_sign_on_spec.rb
View File

@ -48,6 +48,8 @@ describe DiscourseSingleSignOn do
expect(sso.email).to eq "sam@sam.com"
end
let(:ip_address) { "127.0.0.1" }
it "can lookup or create user when name is blank" do
# so we can create system messages
Fabricate(:admin)
@ -56,7 +58,7 @@ describe DiscourseSingleSignOn do
sso.name = ""
sso.email = "test@test.com"
sso.external_id = "A"
user = sso.lookup_or_create_user
user = sso.lookup_or_create_user(ip_address)
expect(user).to_not be_nil
end
@ -123,7 +125,7 @@ describe DiscourseSingleSignOn do
it "deal with no avatar url passed for an existing user with an avatar" do
# Deliberately not setting avatar_url.
user = sso.lookup_or_create_user
user = sso.lookup_or_create_user(ip_address)
expect(user).to_not be_nil
end
@ -133,7 +135,7 @@ describe DiscourseSingleSignOn do
sso.avatar_url = "http://example.com/a_different_image.png"
sso.avatar_force_update = true
user = sso.lookup_or_create_user
user = sso.lookup_or_create_user(ip_address)
expect(user).to_not be_nil
end
end