github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 11:11:13 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Apply syntax_tree formatting to spec/*

Browse Source
This commit is contained in:
David Taylor
2023-01-09 11:18:21 +00:00
parent 0cf6421716
commit cb932d6ee1
907 changed files with 58693 additions and 45909 deletions
Download Patch File Download Diff File Expand all files Collapse all files

165
spec/models/topic_timer_spec.rb
View File

@ -26,75 +26,83 @@ RSpec.describe TopicTimer, type: :model do
it "does not allow durations <= 0" do
topic_timer.duration_minutes = -1
topic_timer.save
expect(topic_timer.errors.full_messages.first).to include("Duration minutes must be greater than 0.")
expect(topic_timer.errors.full_messages.first).to include(
"Duration minutes must be greater than 0.",
)
end
it "does not allow crazy big durations (20 years in minutes)" do
topic_timer.duration_minutes = 21.years.to_i / 60
topic_timer.save
expect(topic_timer.errors.full_messages.first).to include("Duration minutes cannot be more than 20 years.")
expect(topic_timer.errors.full_messages.first).to include(
"Duration minutes cannot be more than 20 years.",
)
end
end
end
describe '#status_type' do
it 'should ensure that only one active public topic status update exists' do
describe "#status_type" do
it "should ensure that only one active public topic status update exists" do
topic_timer.update!(topic: topic)
Fabricate(:topic_timer, deleted_at: Time.zone.now, topic: topic)
expect { Fabricate(:topic_timer, topic: topic) }
.to raise_error(ActiveRecord::RecordInvalid)
expect { Fabricate(:topic_timer, topic: topic) }.to raise_error(ActiveRecord::RecordInvalid)
end
end
describe '#execute_at' do
describe 'when #execute_at is greater than #created_at' do
it 'should be valid' do
topic_timer = Fabricate.build(:topic_timer,
execute_at: Time.zone.now + 1.hour,
user: Fabricate(:user),
topic: Fabricate(:topic)
)
describe "#execute_at" do
describe "when #execute_at is greater than #created_at" do
it "should be valid" do
topic_timer =
Fabricate.build(
:topic_timer,
execute_at: Time.zone.now + 1.hour,
user: Fabricate(:user),
topic: Fabricate(:topic),
)
expect(topic_timer).to be_valid
end
end
describe 'when #execute_at is smaller than #created_at' do
it 'should not be valid' do
topic_timer = Fabricate.build(:topic_timer,
execute_at: Time.zone.now - 1.hour,
created_at: Time.zone.now,
user: Fabricate(:user),
topic: Fabricate(:topic)
)
describe "when #execute_at is smaller than #created_at" do
it "should not be valid" do
topic_timer =
Fabricate.build(
:topic_timer,
execute_at: Time.zone.now - 1.hour,
created_at: Time.zone.now,
user: Fabricate(:user),
topic: Fabricate(:topic),
)
expect(topic_timer).to_not be_valid
end
end
end
describe '#category_id' do
describe 'when #status_type is publish_to_category' do
describe 'when #category_id is not present' do
it 'should not be valid' do
topic_timer = Fabricate.build(:topic_timer,
status_type: TopicTimer.types[:publish_to_category]
)
describe "#category_id" do
describe "when #status_type is publish_to_category" do
describe "when #category_id is not present" do
it "should not be valid" do
topic_timer =
Fabricate.build(:topic_timer, status_type: TopicTimer.types[:publish_to_category])
expect(topic_timer).to_not be_valid
expect(topic_timer.errors).to include(:category_id)
end
end
describe 'when #category_id is present' do
it 'should be valid' do
topic_timer = Fabricate.build(:topic_timer,
status_type: TopicTimer.types[:publish_to_category],
category_id: Fabricate(:category).id,
user: Fabricate(:user),
topic: Fabricate(:topic)
)
describe "when #category_id is present" do
it "should be valid" do
topic_timer =
Fabricate.build(
:topic_timer,
status_type: TopicTimer.types[:publish_to_category],
category_id: Fabricate(:category).id,
user: Fabricate(:user),
topic: Fabricate(:topic),
)
expect(topic_timer).to be_valid
end
@ -103,55 +111,45 @@ RSpec.describe TopicTimer, type: :model do
end
end
describe 'Callbacks' do
describe 'when #execute_at and #user_id are not changed' do
it 'should not schedule another to update topic' do
describe "Callbacks" do
describe "when #execute_at and #user_id are not changed" do
it "should not schedule another to update topic" do
Jobs.expects(:enqueue_at).never
topic_timer.update!(topic: Fabricate(:topic))
end
end
describe 'when a open topic status update is created for an open topic' do
describe "when a open topic status update is created for an open topic" do
fab!(:topic) { Fabricate(:topic, closed: false) }
fab!(:topic_timer) do
Fabricate(:topic_timer,
status_type: described_class.types[:open],
topic: topic
)
Fabricate(:topic_timer, status_type: described_class.types[:open], topic: topic)
end
before do
Jobs.run_immediately!
end
before { Jobs.run_immediately! }
it 'should close the topic' do
it "should close the topic" do
topic_timer.send(:schedule_auto_open_job)
expect(topic.reload.closed).to eq(true)
end
end
describe 'when a close topic status update is created for a closed topic' do
describe "when a close topic status update is created for a closed topic" do
fab!(:topic) { Fabricate(:topic, closed: true) }
fab!(:topic_timer) do
Fabricate(:topic_timer,
status_type: described_class.types[:close],
topic: topic
)
Fabricate(:topic_timer, status_type: described_class.types[:close], topic: topic)
end
before do
Jobs.run_immediately!
end
before { Jobs.run_immediately! }
it 'should open the topic' do
it "should open the topic" do
topic_timer.send(:schedule_auto_close_job)
expect(topic.reload.closed).to eq(false)
end
end
describe '#public_type' do
[:close, :open, :delete].each do |public_type|
describe "#public_type" do
%i[close open delete].each do |public_type|
it "is true for #{public_type}" do
timer = Fabricate(:topic_timer, status_type: described_class.types[public_type])
expect(timer.public_type).to eq(true)
@ -159,7 +157,12 @@ RSpec.describe TopicTimer, type: :model do
end
it "is true for publish_to_category" do
timer = Fabricate(:topic_timer, status_type: described_class.types[:publish_to_category], category: Fabricate(:category))
timer =
Fabricate(
:topic_timer,
status_type: described_class.types[:publish_to_category],
category: Fabricate(:category),
)
expect(timer.public_type).to eq(true)
end
@ -174,34 +177,40 @@ RSpec.describe TopicTimer, type: :model do
describe "runnable?" do
it "returns false if execute_at > now" do
topic_timer = Fabricate.build(:topic_timer,
execute_at: Time.zone.now + 1.hour,
user: Fabricate(:user),
topic: Fabricate(:topic)
)
topic_timer =
Fabricate.build(
:topic_timer,
execute_at: Time.zone.now + 1.hour,
user: Fabricate(:user),
topic: Fabricate(:topic),
)
expect(topic_timer.runnable?).to eq(false)
end
it "returns false if timer is deleted" do
topic_timer = Fabricate.create(:topic_timer,
execute_at: Time.zone.now - 1.hour,
created_at: Time.zone.now - 2.hour,
user: Fabricate(:user),
topic: Fabricate(:topic)
)
topic_timer =
Fabricate.create(
:topic_timer,
execute_at: Time.zone.now - 1.hour,
created_at: Time.zone.now - 2.hour,
user: Fabricate(:user),
topic: Fabricate(:topic),
)
topic_timer.trash!
expect(topic_timer.runnable?).to eq(false)
end
it "returns true if execute_at < now" do
topic_timer = Fabricate.build(:topic_timer,
execute_at: Time.zone.now - 1.hour,
created_at: Time.zone.now - 2.hour,
user: Fabricate(:user),
topic: Fabricate(:topic)
)
topic_timer =
Fabricate.build(
:topic_timer,
execute_at: Time.zone.now - 1.hour,
created_at: Time.zone.now - 2.hour,
user: Fabricate(:user),
topic: Fabricate(:topic),
)
expect(topic_timer.runnable?).to eq(true)
end