UX: modal > remove obsolete wrapper class (#24381)

app/assets/javascripts/discourse/app/components/d-modal.hbs

@@ -17,7 +17,7 @@
     {{will-destroy this.cleanupListeners}}
     {{trap-tab preventScroll=false}}
   >
-    <div class="d-modal__wrapper">
+
     <div class="d-modal__container">
       {{yield to="aboveHeader"}}
 
@@ -95,7 +95,6 @@
 
       {{yield to="belowFooter"}}
     </div>
-    </div>
   </this.dynamicElement>
   {{#unless @inline}}
     <div class="d-modal__backdrop" {{on "click" this.handleWrapperClick}}></div>

app/assets/stylesheets/common/base/modal.scss

@@ -3,7 +3,6 @@
 .d-modal {
   pointer-events: none; // Allow clicks through wrappers so they hit the adjacent backdrop element
 
-  &__wrapper {
   display: flex;
   align-items: center;
   width: 100%;
@@ -13,14 +12,13 @@
   z-index: z("modal", "content");
   overflow: auto;
 
-    .-inline & {
+  &.-inline {
     position: relative;
   }
 
   html.keyboard-visible body.ios-safari-composer-hacks & {
     height: calc(var(--composer-vh, 1vh) * 100);
   }
-  }
 
   &__container {
     display: flex;

app/assets/stylesheets/common/modal/modal-overrides.scss

@@ -266,9 +266,7 @@
 
 .d-modal.chat-modal-new-message {
   .d-modal {
-    &__wrapper {
     align-items: flex-start;
-    }
     &__container {
       width: var(--modal-max-width);
       margin-top: 1rem;

app/assets/stylesheets/mobile/modal.scss

@@ -5,9 +5,6 @@
     width: 100%;
     max-width: 100%;
   }
-  .modal-inner-container {
-    width: 100%;
-  }
 }
 
 //legacy

spec/system/page_objects/modals/base.rb

@@ -25,7 +25,7 @@ module PageObjects
       end
 
       def click_outside
-        find(".d-modal__wrapper").click(x: 0, y: 0)
+        find(".d-modal").click(x: 0, y: 0)
       end
 
       def click_primary_button