github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 23:21:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: Poll breakdown 2.0 (#10345)

Browse Source 
The poll breakdown modal replaces the grouped pie charts feature.

Includes:

* MODAL: Untangle `onSelectPanel`
Previously modal-tab component would call on click the onSelectPanel callback with itself (modal-tab) as `this` which severely limited its usefulness. Now showModal binds the callback to its controller.

"The PR includes a fix/change to d-modal (b7f6ec6) that hasn't been extracted to a separate PR because it's not currently possible to test a change like this in abstract, i.e. with dynamically created controllers/components in tests. The percentage/count toggle test for the poll breakdown feature is essentially a test for that d-modal modification."
This commit is contained in:
Jarek Radosz
2020-08-06 17:57:06 +02:00
committed by GitHub
parent 76c02cac65
commit cd4f251891
26 changed files with 708 additions and 294 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/poll/assets/javascripts/initializers/add-poll-ui-builder.js.es6
View File

@ -1,6 +1,6 @@
import { withPluginApi } from "discourse/lib/plugin-api";
import discourseComputed from "discourse-common/utils/decorators";
import showModal from "discourse/lib/show-modal";
import discourseComputed from "discourse-common/utils/decorators";
function initializePollUIBuilder(api) {
api.modifyClass("controller:composer", {