github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 03:36:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add user api key client rate limit settings (#30402)

Browse Source
This commit is contained in:
Angus McLeod
2024-12-30 17:10:48 +01:00
committed by GitHub
parent 9a22e8d2f1
commit ce7a14104b
3 changed files with 62 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
spec/requests/user_api_key_clients_controller_spec.rb
View File

@ -84,6 +84,45 @@ RSpec.describe UserApiKeyClientsController do
expect(response.status).to eq(403)
end
end
context "with rate limiting" do
before { RateLimiter.enable }
it "works" do
SiteSetting.user_api_key_clients_create_per_day = 1
post "/user-api-key-client.json", params: args_with_scopes
expect(response.status).to eq(200)
post "/user-api-key-client.json",
params: args_with_scopes.merge(client_id: "another_client1")
expect(response.status).to eq(429)
end
it "can be changed via site setting" do
SiteSetting.user_api_key_clients_create_per_day = 2
post "/user-api-key-client.json", params: args_with_scopes
expect(response.status).to eq(200)
post "/user-api-key-client.json",
params: args_with_scopes.merge(client_id: "another_client1")
expect(response.status).to eq(200)
post "/user-api-key-client.json",
params: args_with_scopes.merge(client_id: "another_client2")
expect(response.status).to eq(429)
end
it "can be overriden by ip address set in a site setting" do
SiteSetting.user_api_key_clients_create_per_day = 1
SiteSetting.create_user_api_key_client_ip_rate_limit_override_ips = "1.2.3.4"
post "/user-api-key-client.json", params: args_with_scopes
expect(response.status).to eq(200)
post "/user-api-key-client.json",
params: args_with_scopes.merge(client_id: "another_client1"),
env: {
REMOTE_ADDR: "1.2.3.4",
}
expect(response.status).to eq(200)
end
end
end
end
end