Revert "Revert "BUGFIX: improve error messages for invalid API keys""

This reverts commit e9afe28586cd887b92fa86c52db78d543a70e433.
This commit is contained in:
Sam
2014-05-23 08:13:25 +10:00
parent 43bac5467a
commit cf254000cf
6 changed files with 94 additions and 40 deletions

View File

@ -638,7 +638,7 @@ describe TopicsController do
end
context "when 'login required' site setting has been enabled" do
before { SiteSetting.stubs(:login_required?).returns(true) }
before { SiteSetting.login_required = true }
context 'and the user is logged in' do
before { log_in(:coding_horror) }
@ -662,9 +662,9 @@ describe TopicsController do
expect(response).to be_successful
end
it 'redirects to the login page if invalid key is provided' do
it 'returns 403 for an invalid key' do
get :show, topic_id: topic.id, slug: topic.slug, api_key: "bad"
expect(response).to redirect_to login_path
expect(response.code.to_i).to be(403)
end
end
end