github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 16:11:08 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: stop freezing frozen strings

Browse Source 
We have the `# frozen_string_literal: true` comment on all our
files. This means all string literals are frozen. There is no need
to call #freeze on any literals.

For files with `# frozen_string_literal: true`

```
puts %w{a b}[0].frozen?
=> true

puts "hi".frozen?
=> true

puts "a #{1} b".frozen?
=> true

puts ("a " + "b").frozen?
=> false

puts (-("a " + "b")).frozen?
=> true
```

For more details see: https://samsaffron.com/archive/2018/02/16/reducing-string-duplication-in-ruby
This commit is contained in:
Sam Saffron
2020-04-30 16:48:34 +10:00
parent 02ef88052d
commit d0d5a138c3
51 changed files with 98 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/controllers/webhooks_controller.rb
View File

@ -15,13 +15,13 @@ class WebhooksController < ActionController::Base
events.each do |event|
message_id = (event["smtp-id"] || "").tr("<>", "")
to_address = event["email"]
if event["event"] == "bounce".freeze
if event["event"] == "bounce"
if event["status"]["4."]
process_bounce(message_id, to_address, SiteSetting.soft_bounce_score)
else
process_bounce(message_id, to_address, SiteSetting.hard_bounce_score)
end
elsif event["event"] == "dropped".freeze
elsif event["event"] == "dropped"
process_bounce(message_id, to_address, SiteSetting.hard_bounce_score)
end
end
@ -34,7 +34,7 @@ class WebhooksController < ActionController::Base
events.each do |event|
message_id = event["CustomID"]
to_address = event["email"]
if event["event"] == "bounce".freeze
if event["event"] == "bounce"
if event["hard_bounce"]
process_bounce(message_id, to_address, SiteSetting.hard_bounce_score)
else
@ -156,9 +156,9 @@ class WebhooksController < ActionController::Base
# only handle soft bounces, because hard bounces are also handled
# by the "dropped" event and we don't want to increase bounce score twice
# for the same message
if event == "bounced".freeze && params["error"]["4."]
if event == "bounced" && params["error"]["4."]
process_bounce(message_id, to_address, SiteSetting.soft_bounce_score)
elsif event == "dropped".freeze
elsif event == "dropped"
process_bounce(message_id, to_address, SiteSetting.hard_bounce_score)
end
@ -174,10 +174,10 @@ class WebhooksController < ActionController::Base
to_address = data["recipient"]
severity = data["severity"]
if data["event"] == "failed".freeze
if severity == "temporary".freeze
if data["event"] == "failed"
if severity == "temporary"
process_bounce(message_id, to_address, SiteSetting.soft_bounce_score)
elsif severity == "permanent".freeze
elsif severity == "permanent"
process_bounce(message_id, to_address, SiteSetting.hard_bounce_score)
end
end