github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: stop freezing frozen strings

Browse Source 
We have the `# frozen_string_literal: true` comment on all our
files. This means all string literals are frozen. There is no need
to call #freeze on any literals.

For files with `# frozen_string_literal: true`

```
puts %w{a b}[0].frozen?
=> true

puts "hi".frozen?
=> true

puts "a #{1} b".frozen?
=> true

puts ("a " + "b").frozen?
=> false

puts (-("a " + "b")).frozen?
=> true
```

For more details see: https://samsaffron.com/archive/2018/02/16/reducing-string-duplication-in-ruby
This commit is contained in:
Sam Saffron
2020-04-30 16:48:34 +10:00
parent 02ef88052d
commit d0d5a138c3
51 changed files with 98 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/discourse.rb
View File

@ -42,7 +42,7 @@ module Discourse
end
def self.pretty_logs(logs)
logs.join("\n".freeze)
logs.join("\n")
end
def self.atomic_write_file(destination, contents)
@ -811,7 +811,7 @@ module Discourse
warning
end
SIDEKIQ_NAMESPACE ||= 'sidekiq'.freeze
SIDEKIQ_NAMESPACE ||= 'sidekiq'
def self.sidekiq_redis_config
conf = GlobalSetting.redis_config.dup