github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 06:48:47 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Move sidebar site settings to the sidebar category (#18596)

Browse Source 
Sidebar category is only shown in the admin panel when `enable_experimental_sidebar_hamburger` site setting is enabled
This commit is contained in:
Alan Guo Xiang Tan
2022-10-17 10:33:15 +08:00
committed by GitHub
parent 3d59f767ae
commit d1304ecb46
3 changed files with 62 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
spec/lib/site_setting_extension_spec.rb
View File

@ -832,4 +832,24 @@ RSpec.describe SiteSettingExtension do
end
end
end
describe 'sidebar category site settings' do
describe '.all_settings' do
before do
settings.setting(:test_setting, 88, category: :sidebar)
end
it 'does not include the sidebar category setting when enable_experimental_sidebar_hamburger site setting is disabled' do
SiteSetting.enable_experimental_sidebar_hamburger = false
expect(settings.all_settings.detect { |s| s[:setting] == :test_setting }).to eq(nil)
end
it 'includes the sidebar category setting when enable_experimental_sidebar_hamburger site setting is enabled' do
SiteSetting.enable_experimental_sidebar_hamburger = true
expect(settings.all_settings.detect { |s| s[:setting] == :test_setting }[:setting]).to eq(:test_setting)
end
end
end
end