github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-01 02:04:53 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: check if user can_chat inside the can_join_chat_channel guardian (#21812)

Browse Source 
Someone who cannot chat is also not able to join chat channels, 
so we may not check all the time user.can_chat? && user.can_join_chat_channel? 
and just call user.can_join_chat_channel? instead.
This commit is contained in:
Andrei Prigorshnev
2023-07-19 21:55:00 +04:00
committed by GitHub
parent e1d27400f5
commit d1760727cf
12 changed files with 34 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/chat/spec/system/react_to_message_spec.rb
View File

@ -1,8 +1,8 @@
# frozen_string_literal: true
RSpec.describe "React to message", type: :system do
fab!(:current_user) { Fabricate(:user) }
fab!(:other_user) { Fabricate(:user) }
fab!(:current_user) { Fabricate(:user, group_ids: [Group::AUTO_GROUPS[:trust_level_1]]) }
fab!(:other_user) { Fabricate(:user, group_ids: [Group::AUTO_GROUPS[:trust_level_1]]) }
fab!(:category_channel_1) { Fabricate(:category_channel) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: category_channel_1) }
@ -137,7 +137,7 @@ RSpec.describe "React to message", type: :system do
end
context "when current user and another have reacted" do
fab!(:other_user) { Fabricate(:user) }
fab!(:other_user) { Fabricate(:user, group_ids: [Group::AUTO_GROUPS[:trust_level_1]]) }
fab!(:reaction_1) do
Chat::MessageReactor.new(current_user, category_channel_1).react!(
@ -205,7 +205,7 @@ RSpec.describe "React to message", type: :system do
end
context "when receiving a duplicate reaction event" do
fab!(:user_1) { Fabricate(:user) }
fab!(:user_1) { Fabricate(:user, group_ids: [Group::AUTO_GROUPS[:trust_level_1]]) }
fab!(:reaction_2) do
Chat::MessageReactor.new(user_1, category_channel_1).react!(