Add new run_jobs_synchronously! helper for tests

Previously if you wanted to have jobs execute in test mode, you'd have
to do `SiteSetting.queue_jobs = false`, because the opposite of queue
is to execute.

I found this very confusing, so I created a test helper called
`run_jobs_synchronously!` which is much more clear about what it does.
This commit is contained in:
Robin Ward
2019-03-11 16:58:35 -04:00
parent 2ee02cb6c7
commit d1d9a4f128
33 changed files with 51 additions and 45 deletions

View File

@ -22,7 +22,7 @@ RSpec.describe DiscourseNarrativeBot::AdvancedUserNarrative do
let(:reset_trigger) { DiscourseNarrativeBot::TrackSelector.reset_trigger }
before do
SiteSetting.queue_jobs = false
run_jobs_synchronously!
SiteSetting.discourse_narrative_bot_enabled = true
end

View File

@ -25,7 +25,7 @@ describe DiscourseNarrativeBot::NewUserNarrative do
let(:reset_trigger) { DiscourseNarrativeBot::TrackSelector.reset_trigger }
before do
SiteSetting.queue_jobs = false
run_jobs_synchronously!
SiteSetting.discourse_narrative_bot_enabled = true
end

View File

@ -37,7 +37,7 @@ describe DiscourseNarrativeBot::TrackSelector do
end
before do
SiteSetting.queue_jobs = false
run_jobs_synchronously!
end
describe '#select' do

View File

@ -13,7 +13,7 @@ describe User do
end
before do
SiteSetting.queue_jobs = false
run_jobs_synchronously!
SiteSetting.discourse_narrative_bot_enabled = true
end