Allow plugins to ship custom styles only for mobile

- adds another :mobile-flag to register_assets
- adds test for plugin registering of assets
- load plugins when on desktop and plugins_mobile when on mobile
This commit is contained in:
Benjamin Kampmann
2014-04-07 16:33:35 +02:00
parent 4a2438edc3
commit d22df7731d
7 changed files with 97 additions and 5 deletions

View File

@ -5,7 +5,10 @@ describe Plugin::Instance do
after do
DiscoursePluginRegistry.javascripts.clear
DiscoursePluginRegistry.admin_javascripts.clear
DiscoursePluginRegistry.server_side_javascripts.clear
DiscoursePluginRegistry.stylesheets.clear
DiscoursePluginRegistry.mobile_stylesheets.clear
end
context "find_all" do
@ -24,6 +27,37 @@ describe Plugin::Instance do
end
end
context "register asset" do
it "does register css properly" do
plugin = Plugin::Instance.new nil, "/tmp/test.rb"
plugin.register_asset("test.css")
plugin.assets.count.should == 1
plugin.register_asset("test2.css")
plugin.assets.count.should == 2
end
it "does register mobile css properly" do
plugin = Plugin::Instance.new nil, "/tmp/test.rb"
plugin.register_asset("test.css", :mobile)
plugin.assets.count.should == 0
plugin.mobile_styles.count.should == 1
end
it "does register admin javascript properly" do
plugin = Plugin::Instance.new nil, "/tmp/test.rb"
plugin.register_asset("my_admin.js", :admin)
plugin.assets.count.should == 0
plugin.admin_javascripts.count.should == 1
end
it "does register server side javascript properly" do
plugin = Plugin::Instance.new nil, "/tmp/test.rb"
plugin.register_asset("my_admin.js", :server_side)
# server side is both in assets and in server_side
plugin.assets.count.should == 1
plugin.server_side_javascripts.count.should == 1
end
end
context "activate!" do
it "can activate plugins correctly" do
plugin = Plugin::Instance.new
@ -47,6 +81,31 @@ describe Plugin::Instance do
# ensure it cleans up all crap in autogenerated directory
File.exists?(junk_file).should be_false
end
it "finds all the custom assets" do
plugin = Plugin::Instance.new
plugin.path = "#{Rails.root}/spec/fixtures/plugins/my_plugin/plugin.rb"
# two styles
plugin.register_asset("test.css")
plugin.register_asset("test2.scss")
# one javascript
plugin.register_asset("code.js")
# one mobile
plugin.register_asset("test.css", :mobile)
# a server side
plugin.register_asset("server_side.js", :server_side)
# and two admin
plugin.register_asset("my_admin.js", :admin)
plugin.register_asset("my_admin2.js", :admin)
plugin.activate!
DiscoursePluginRegistry.javascripts.count.should == 3
DiscoursePluginRegistry.admin_javascripts.count.should == 2
DiscoursePluginRegistry.server_side_javascripts.count.should == 1
DiscoursePluginRegistry.stylesheets.count.should == 2
DiscoursePluginRegistry.mobile_stylesheets.count.should == 1
end
end
end