github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 18:01:25 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Introduce TemporaryRedis and unset DISCOURSE_* env vars in the themes:isolated_test rake task (#13401)

Browse Source 
The `themes:isolated_test` rake task will now unset all `DISCOURSE_*` env variables if `UNSET_DISCOURSE_ENV_VARS` env var is set and will also spin up a temporary redis server so the unicorn web server that's spun up for the tests doesn't leak into the "main" redis server.
This commit is contained in:
Osama Sayegh
2021-06-23 07:38:43 +03:00
committed by GitHub
parent 30c7a9b06d
commit d3a3d1b94c
3 changed files with 129 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/tasks/qunit.rake
View File

@ -42,7 +42,10 @@ task "qunit:test", [:timeout, :qunit_path] do |_, args|
"UNICORN_PID_PATH" => "#{Rails.root}/tmp/pids/unicorn_test_#{port}.pid", # So this can run alongside development
"UNICORN_PORT" => port.to_s,
"UNICORN_SIDEKIQS" => "0",
"DISCOURSE_SKIP_CSS_WATCHER" => "1"
"DISCOURSE_SKIP_CSS_WATCHER" => "1",
"UNICORN_LISTENER" => "127.0.0.1:#{port}",
"LOGSTASH_UNICORN_URI" => nil,
"UNICORN_WORKERS" => "3"
},
"#{Rails.root}/bin/unicorn -c config/unicorn.conf.rb",
pgroup: true

19
lib/tasks/themes.rake
View File

@ -120,7 +120,22 @@ task "themes:qunit", :type, :value do |t, args|
end
desc "Install a theme/component on a temporary DB and run QUnit tests"
task "themes:install_and_test" => :environment do |t, args|
task "themes:isolated_test" => :environment do |t, args|
# This task can be called in a production environment that likely has a bunch
# of DISCOURSE_* env vars that we don't want to be picked up by the Unicorn
# server that will be spawned for the tests. So we need to unset them all
# before we proceed.
# Make this behavior opt-in to make it very obvious.
if ENV["UNSET_DISCOURSE_ENV_VARS"] == "1"
ENV.keys.each do |key|
next if !key.start_with?('DISCOURSE_')
ENV[key] = nil
end
end
redis = TemporaryRedis.new
redis.start
$redis = redis.instance # rubocop:disable Style/GlobalVars
db = TemporaryDb.new
db.start
db.migrate
@ -139,6 +154,7 @@ task "themes:install_and_test" => :environment do |t, args|
ENV["PGHOST"] = "localhost"
ENV["QUNIT_RAILS_ENV"] = "development"
ENV["DISCOURSE_DEV_DB"] = "discourse"
ENV["DISCOURSE_REDIS_PORT"] = redis.port.to_s
count = 0
themes.each do |(name, id)|
@ -155,4 +171,5 @@ task "themes:install_and_test" => :environment do |t, args|
ensure
db&.stop
db&.remove
redis&.remove
end