github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-29 01:31:35 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Add configurable? helper to Plugin::Instance (#21472)

Browse Source 
This reapplies commit 3073e5cfb0721b3b8009963c5fc7f61d414db317, with
a fix that makes sure that plugins can be looked up both by the name
present in metadata and directory name.
This commit is contained in:
Bianca Nenciu
2023-05-10 15:21:48 +02:00
committed by GitHub
parent b713ae166f
commit d3a5a493fa
6 changed files with 107 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/controllers/admin/site_settings_controller.rb
View File

@ -259,10 +259,15 @@ class Admin::SiteSettingsController < Admin::AdminController
end
def raise_access_hidden_setting(id)
# note, as of Ruby 2.3 symbols are GC'd so this is considered safe
if SiteSetting.hidden_settings.include?(id.to_sym)
id = id.to_sym
if SiteSetting.hidden_settings.include?(id)
raise Discourse::InvalidParameters, "You are not allowed to change hidden settings"
end
if SiteSetting.plugins[id] && !Discourse.plugins_by_name[SiteSetting.plugins[id]].configurable?
raise Discourse::InvalidParameters, "You are not allowed to change unconfigurable settings"
end
end
def tag_notification_level(id)