github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-07 21:44:42 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: fixes flakey due to unordered array (#22515)

Browse Source 
The `message_bus_channels` given to `MessageBus.last_ids(*message_bus_channels)` is not ordered, as a result the expectation of the tests could fail, this test ensures we check the contain of the input instead of content+order.
This commit is contained in:
Joffrey JAFFEUX
2023-07-10 17:26:29 +02:00
committed by GitHub
parent 0ce0bcd8ff
commit d52b0560ff
1 changed files with 25 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/chat/spec/serializer/chat/structured_channel_serializer_spec.rb
View File

@ -135,7 +135,8 @@ RSpec.describe Chat::StructuredChannelSerializer do
it "calls MessageBus.last_ids with all the required channels for each public and DM chat chat channel" do it "calls MessageBus.last_ids with all the required channels for each public and DM chat chat channel" do
MessageBus MessageBus
.expects(:last_ids) .expects(:last_ids)
.with( .with do |*args|
[
Chat::Publisher::CHANNEL_METADATA_MESSAGE_BUS_CHANNEL, Chat::Publisher::CHANNEL_METADATA_MESSAGE_BUS_CHANNEL,
Chat::Publisher::CHANNEL_EDITS_MESSAGE_BUS_CHANNEL, Chat::Publisher::CHANNEL_EDITS_MESSAGE_BUS_CHANNEL,
Chat::Publisher::CHANNEL_STATUS_MESSAGE_BUS_CHANNEL, Chat::Publisher::CHANNEL_STATUS_MESSAGE_BUS_CHANNEL,
@ -156,8 +157,10 @@ RSpec.describe Chat::StructuredChannelSerializer do
Chat::Publisher.new_messages_message_bus_channel(channel4.id), Chat::Publisher.new_messages_message_bus_channel(channel4.id),
Chat::Publisher.new_mentions_message_bus_channel(channel4.id), Chat::Publisher.new_mentions_message_bus_channel(channel4.id),
Chat::Publisher.root_message_bus_channel(channel4.id), Chat::Publisher.root_message_bus_channel(channel4.id),
) ].to_set == args.to_set
end
.returns({}) .returns({})
described_class.new(fetch_data, scope: guardian).as_json described_class.new(fetch_data, scope: guardian).as_json
end end