github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 03:36:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Don’t replace Rails logger in specs (#29721)

Browse Source 
Instead of replacing the Rails logger in specs, we can instead use
`#broadcast_to` which has been introduced in Rails 7.
This commit is contained in:
Loïc Guitaut
2024-11-13 01:47:39 +01:00
committed by GitHub
parent 907fbd6f1e
commit d637bd6519
17 changed files with 113 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/lib/discourse_ip_info_spec.rb
View File

@ -62,8 +62,8 @@ RSpec.describe DiscourseIpInfo do
end
it "should not throw an error and instead log the exception when database file fails to download" do
original_logger = Rails.logger
Rails.logger = fake_logger = FakeLogger.new
fake_logger = FakeLogger.new
Rails.logger.broadcast_to(fake_logger)
global_setting :maxmind_license_key, "license_key"
global_setting :maxmind_account_id, "account_id"
@ -81,7 +81,7 @@ RSpec.describe DiscourseIpInfo do
"MaxMind database GeoLite2-City download failed. 500 Error",
)
ensure
Rails.logger = original_logger
Rails.logger.stop_broadcasting_to(fake_logger)
end
end
end