mirror of
https://github.com/discourse/discourse.git
synced 2025-05-25 00:01:24 +08:00
DEV: Don’t replace Rails logger in specs (#29721)
Instead of replacing the Rails logger in specs, we can instead use `#broadcast_to` which has been introduced in Rails 7.
This commit is contained in:
@ -1,12 +1,11 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
RSpec.describe Middleware::DiscoursePublicExceptions do
|
||||
before do
|
||||
@orig_logger = Rails.logger
|
||||
Rails.logger = @fake_logger = FakeLogger.new
|
||||
end
|
||||
let(:fake_logger) { FakeLogger.new }
|
||||
|
||||
after { Rails.logger = @orig_logger }
|
||||
before { Rails.logger.broadcast_to(fake_logger) }
|
||||
|
||||
after { Rails.logger.stop_broadcasting_to(fake_logger) }
|
||||
|
||||
def env(opts = {})
|
||||
{
|
||||
@ -27,6 +26,6 @@ RSpec.describe Middleware::DiscoursePublicExceptions do
|
||||
),
|
||||
)
|
||||
|
||||
expect(@fake_logger.warnings.length).to eq(0)
|
||||
expect(fake_logger.warnings.length).to eq(0)
|
||||
end
|
||||
end
|
||||
|
Reference in New Issue
Block a user