DEV: Plugin scss errors should break precompile (#6974)

This commit is contained in:
Penar Musaraj
2019-02-07 09:27:42 -05:00
committed by GitHub
parent 6c195640b9
commit d639cadb7a
4 changed files with 5 additions and 16 deletions

View File

@ -6,16 +6,6 @@ module Stylesheet
class Compiler
def self.error_as_css(error, label)
error = error.message
error.gsub!("\n", '\A ')
error.gsub!("'", '\27 ')
"#main { display: none; }
body { white-space: pre; }
body:before { font-family: monospace; content: '#{error}' }"
end
def self.compile_asset(asset, options = {})
if Importer.special_imports[asset.to_s]

View File

@ -166,15 +166,11 @@ class Stylesheet::Manager
source_map_file: source_map_filename
)
rescue SassC::SyntaxError => e
# we do not need this reported as we will report it in the UI anyway
Rails.logger.info "Failed to compile #{@target} stylesheet: #{e.message}"
if %w{embedded_theme mobile_theme desktop_theme}.include?(@target.to_s)
# no special errors for theme, handled in theme editor
["", nil]
else
[Stylesheet::Compiler.error_as_css(e, "#{@target} stylesheet"), nil]
raise Discourse::ScssError, e.message
end
end