From db89722a98dc6ce3489c5f0cbc38b03d3d1a181a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Hanol?= Date: Wed, 15 May 2019 22:22:20 +0200 Subject: [PATCH] UX: ignore leading/trailing whitespaces in site settings search --- .../javascripts/admin/controllers/admin-site-settings.js.es6 | 2 +- test/javascripts/acceptance/admin-site-settings-test.js.es6 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/admin/controllers/admin-site-settings.js.es6 b/app/assets/javascripts/admin/controllers/admin-site-settings.js.es6 index 9473cbccae5..0728ee8ae15 100644 --- a/app/assets/javascripts/admin/controllers/admin-site-settings.js.es6 +++ b/app/assets/javascripts/admin/controllers/admin-site-settings.js.es6 @@ -12,7 +12,7 @@ export default Ember.Controller.extend({ let filter; if (this.get("filter")) { - filter = this.get("filter").toLowerCase(); + filter = this.get("filter").toLowerCase().trim(); } if ((!filter || 0 === filter.length) && !this.get("onlyOverridden")) { diff --git a/test/javascripts/acceptance/admin-site-settings-test.js.es6 b/test/javascripts/acceptance/admin-site-settings-test.js.es6 index 44ed23aec0b..e52b967e053 100644 --- a/test/javascripts/acceptance/admin-site-settings-test.js.es6 +++ b/test/javascripts/acceptance/admin-site-settings-test.js.es6 @@ -42,7 +42,7 @@ QUnit.test("upload site setting", async assert => { QUnit.test("changing value updates dirty state", async assert => { await visit("/admin/site_settings"); - await fillIn("#setting-filter", "title"); + await fillIn("#setting-filter", " title "); assert.equal(count(".row.setting"), 1, "filter returns 1 site setting"); assert.ok(!exists(".row.setting.overridden"), "setting isn't overriden");