github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Don't allow staff to approve users with unverified emails

Browse Source
This commit is contained in:
Robin Ward
2017-09-04 12:55:23 -04:00
parent 153eca23e3
commit db929e58fc
5 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/components/admin_user_index_query_spec.rb
View File

@ -100,18 +100,20 @@ describe AdminUserIndexQuery do
describe "with a pending user" do
let!(:user) { Fabricate(:user, approved: false) }
let!(:user) { Fabricate(:user, active: true, approved: false) }
let!(:inactive_user) { Fabricate(:user, approved: false, active: false) }
it "finds the unapproved user" do
query = ::AdminUserIndexQuery.new(query: 'pending')
expect(query.find_users.count).to eq(1)
expect(query.find_users).to include(user)
expect(query.find_users).not_to include(inactive_user)
end
context 'and a suspended pending user' do
let!(:suspended_user) { Fabricate(:user, approved: false, suspended_at: 1.hour.ago, suspended_till: 20.years.from_now) }
it "doesn't return the suspended user" do
query = ::AdminUserIndexQuery.new(query: 'pending')
expect(query.find_users.count).to eq(1)
expect(query.find_users).not_to include(suspended_user)
end
end