github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-26 12:05:25 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Code style improvements following review

Browse Source 
Followup to 05ee1d1aba3d1238867b59d91b72327688358439
This commit is contained in:
David Taylor
2019-02-19 20:02:29 +00:00
parent 34b2157b8c
commit dbcf05d62c
3 changed files with 12 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/assets/javascripts/admin/components/admin-theme-editor.js.es6
View File

@ -1,4 +1,5 @@
import { default as computed } from "ember-addons/ember-computed-decorators";
import { fmt } from "discourse/lib/computed";
export default Ember.Component.extend({
@computed("theme.targets", "onlyOverridden", "showAdvanced")
@ -40,10 +41,7 @@ export default Ember.Component.extend({
}
},
@computed("fieldName", "currentTargetName")
editorId(fieldName, currentTarget) {
return fieldName + "|" + currentTarget;
},
editorId: fmt("fieldName", "currentTargetName", "%@|%@"),
@computed("maximized")
maximizeIcon(maximized) {
@ -77,16 +75,13 @@ export default Ember.Component.extend({
if (!name) return;
name = name.replace(/\W/g, "");
this.get("theme").setField(this.get("currentTargetName"), name, "");
this.set("newFieldName", "");
this.set("addingField", false);
this.setProperties({ newFieldName: "", addingField: false });
this.fieldAdded(this.get("currentTargetName"), name);
},
toggleMaximize: function() {
this.toggleProperty("maximized");
Ember.run.next(() => {
this.appEvents.trigger("ace:resize");
});
Ember.run.next(() => this.appEvents.trigger("ace:resize"));
},
onlyOverriddenChanged(value) {