github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Modernize chat's component tests (#19577)

Browse Source 
1. `test()` and `render()` instead of `componentTest()`
2. Angle brackets
3. `strictEqual()`/`true()`/`false()` assertions

This removes all remaining uses of `componentTest` from core
This commit is contained in:
Jarek Radosz
2022-12-22 14:35:18 +01:00
committed by GitHub
parent 8546c2084a
commit dc3473fe06
34 changed files with 1397 additions and 1762 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
plugins/chat/test/javascripts/components/chat-composer-dropdown-test.js
View File

@ -1,28 +1,21 @@
import componentTest, {
setupRenderingTest,
} from "discourse/tests/helpers/component-test";
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import { exists } from "discourse/tests/helpers/qunit-helpers";
import hbs from "htmlbars-inline-precompile";
import { click } from "@ember/test-helpers";
import { module } from "qunit";
import { click, render } from "@ember/test-helpers";
import { module, test } from "qunit";
module("Discourse Chat | Component | chat-composer-dropdown", function (hooks) {
setupRenderingTest(hooks);
componentTest("buttons", {
template: hbs`{{chat-composer-dropdown buttons=buttons}}`,
test("buttons", async function (assert) {
this.set("buttons", [{ id: "foo", icon: "times", action: () => {} }]);
async beforeEach() {
this.set("buttons", [{ id: "foo", icon: "times", action: () => {} }]);
},
await render(hbs`<ChatComposerDropdown @buttons={{this.buttons}} />`);
await click(".chat-composer-dropdown__trigger-btn");
async test(assert) {
await click(".chat-composer-dropdown__trigger-btn");
assert.ok(exists(".chat-composer-dropdown__item.foo"));
assert.ok(
exists(".chat-composer-dropdown__action-btn.foo .d-icon-times")
);
},
assert.true(exists(".chat-composer-dropdown__item.foo"));
assert.true(
exists(".chat-composer-dropdown__action-btn.foo .d-icon-times")
);
});
});