github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 07:53:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Modernize chat's component tests (#19577)

Browse Source 
1. `test()` and `render()` instead of `componentTest()`
2. Angle brackets
3. `strictEqual()`/`true()`/`false()` assertions

This removes all remaining uses of `componentTest` from core
This commit is contained in:
Jarek Radosz
2022-12-22 14:35:18 +01:00
committed by GitHub
parent 8546c2084a
commit dc3473fe06
34 changed files with 1397 additions and 1762 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
plugins/chat/test/javascripts/components/chat-user-display-name-test.js
View File

@ -1,9 +1,8 @@
import componentTest, {
setupRenderingTest,
} from "discourse/tests/helpers/component-test";
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import { query } from "discourse/tests/helpers/qunit-helpers";
import hbs from "htmlbars-inline-precompile";
import { module } from "qunit";
import { module, test } from "qunit";
import { render } from "@ember/test-helpers";
function displayName() {
return query(".chat-user-display-name").innerText.trim();
@ -14,30 +13,22 @@ module(
function (hooks) {
setupRenderingTest(hooks);
componentTest("username and no name", {
template: hbs`{{chat-user-display-name user=user}}`,
test("username and no name", async function (assert) {
this.siteSettings.prioritize_username_in_ux = true;
this.set("user", { username: "bob", name: null });
async beforeEach() {
this.siteSettings.prioritize_username_in_ux = true;
this.set("user", { username: "bob", name: null });
},
await render(hbs`<ChatUserDisplayName @user={{this.user}} />`);
async test(assert) {
assert.equal(displayName(), "bob");
},
assert.strictEqual(displayName(), "bob");
});
componentTest("username and name", {
template: hbs`{{chat-user-display-name user=user}}`,
test("username and name", async function (assert) {
this.siteSettings.prioritize_username_in_ux = true;
this.set("user", { username: "bob", name: "Bobcat" });
async beforeEach() {
this.siteSettings.prioritize_username_in_ux = true;
this.set("user", { username: "bob", name: "Bobcat" });
},
await render(hbs`<ChatUserDisplayName @user={{this.user}} />`);
async test(assert) {
assert.equal(displayName(), "bob — Bobcat");
},
assert.strictEqual(displayName(), "bob — Bobcat");
});
}
);
@ -47,30 +38,22 @@ module(
function (hooks) {
setupRenderingTest(hooks);
componentTest("no name", {
template: hbs`{{chat-user-display-name user=user}}`,
test("no name", async function (assert) {
this.siteSettings.prioritize_username_in_ux = false;
this.set("user", { username: "bob", name: null });
async beforeEach() {
this.siteSettings.prioritize_username_in_ux = false;
this.set("user", { username: "bob", name: null });
},
await render(hbs`<ChatUserDisplayName @user={{this.user}} />`);
async test(assert) {
assert.equal(displayName(), "bob");
},
assert.strictEqual(displayName(), "bob");
});
componentTest("name and username", {
template: hbs`{{chat-user-display-name user=user}}`,
test("name and username", async function (assert) {
this.siteSettings.prioritize_username_in_ux = false;
this.set("user", { username: "bob", name: "Bobcat" });
async beforeEach() {
this.siteSettings.prioritize_username_in_ux = false;
this.set("user", { username: "bob", name: "Bobcat" });
},
await render(hbs`<ChatUserDisplayName @user={{this.user}} />`);
async test(assert) {
assert.equal(displayName(), "Bobcat — bob");
},
assert.strictEqual(displayName(), "Bobcat — bob");
});
}
);