From dca7f8ecf23286f72f8347509eb4e1a2464e02ae Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Tue, 30 Apr 2019 10:33:25 +0800 Subject: [PATCH] FIX: Loading more broken on groups page. Regressed in 1f17d52f552d01cb5ea628294d1b25666631fa87. --- .../discourse/templates/groups/index.hbs | 16 ++++++++-------- app/controllers/groups_controller.rb | 4 +++- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/app/assets/javascripts/discourse/templates/groups/index.hbs b/app/assets/javascripts/discourse/templates/groups/index.hbs index e19bcbbf8cf..955af19e212 100644 --- a/app/assets/javascripts/discourse/templates/groups/index.hbs +++ b/app/assets/javascripts/discourse/templates/groups/index.hbs @@ -23,11 +23,11 @@ {{#if model}} {{#conditional-loading-spinner condition=model.loading}} - {{#load-more selector=".groups-table .groups-table-row" action=(action "loadMore")}} + {{#load-more selector=".groups-boxes .group-box" action=(action "loadMore")}}
{{#each model as |group|}} - {{#link-to "group.members" group.name class="group-box"}} + {{#link-to "group.members" group.name class="group-box"}}
{{#if group.flair_url}} @@ -39,13 +39,13 @@ groupName=group.name}} {{/if}} + - {{groups-info group=group}} - -
{{d-icon "user"}}{{group.user_count}}
-
-
+ {{groups-info group=group}} +
{{d-icon "user"}}{{group.user_count}}
+ +
{{{group.bio_excerpt}}}
@@ -77,7 +77,7 @@ {{/group-membership-button}}
- {{/link-to}} + {{/link-to}} {{/each}} diff --git a/app/controllers/groups_controller.rb b/app/controllers/groups_controller.rb index 9fc82d1e4e8..0fb1694ac55 100644 --- a/app/controllers/groups_controller.rb +++ b/app/controllers/groups_controller.rb @@ -1,4 +1,6 @@ class GroupsController < ApplicationController + include ApplicationHelper + requires_login only: [ :set_notifications, :mentionable, @@ -42,7 +44,7 @@ class GroupsController < ApplicationController raise Discourse::InvalidAccess.new(:enable_group_directory) end - page_size = 30 + page_size = mobile_device? ? 15 : 36 page = params[:page]&.to_i || 0 order = %w{name user_count}.delete(params[:order]) dir = params[:asc] ? 'ASC' : 'DESC'