github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 23:36:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: drop the automatic_membership_retroactive column from groups model. (#9430)

Browse Source
This commit is contained in:
Vinoth Kannan
2020-04-22 22:07:39 +05:30
committed by GitHub
parent bf0c055a9a
commit df0c386f8a
25 changed files with 144 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/requests/groups_controller_spec.rb
View File

@ -657,8 +657,7 @@ describe GroupsController do
mentionable_level: 2,
messageable_level: 2,
default_notification_level: 0,
grant_trust_level: 0,
automatic_membership_retroactive: false
grant_trust_level: 0
)
expect do
@ -668,7 +667,6 @@ describe GroupsController do
messageable_level: 1,
visibility_level: 1,
automatic_membership_email_domains: 'test.org',
automatic_membership_retroactive: true,
title: 'haha',
primary_group: true,
grant_trust_level: 1,
@ -707,7 +705,6 @@ describe GroupsController do
expect(group.messageable_level).to eq(1)
expect(group.default_notification_level).to eq(1)
expect(group.automatic_membership_email_domains).to eq(nil)
expect(group.automatic_membership_retroactive).to eq(false)
expect(group.title).to eq('haha')
expect(group.primary_group).to eq(false)
expect(group.incoming_email).to eq(nil)
@ -737,7 +734,6 @@ describe GroupsController do
group.update!(
visibility_level: 2,
members_visibility_level: 2,
automatic_membership_retroactive: false,
grant_trust_level: 0
)
@ -748,7 +744,6 @@ describe GroupsController do
incoming_email: 'test@mail.org',
primary_group: true,
automatic_membership_email_domains: 'test.org',
automatic_membership_retroactive: true,
grant_trust_level: 2,
visibility_level: 1,
members_visibility_level: 3
@ -765,7 +760,6 @@ describe GroupsController do
expect(group.visibility_level).to eq(1)
expect(group.members_visibility_level).to eq(3)
expect(group.automatic_membership_email_domains).to eq('test.org')
expect(group.automatic_membership_retroactive).to eq(true)
expect(group.grant_trust_level).to eq(2)
expect(Jobs::AutomaticGroupMembership.jobs.first["args"].first["group_id"])