github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove remaining hardcoded ids (#18735)

Browse Source
This commit is contained in:
Jarek Radosz
2022-10-25 09:29:09 +02:00
committed by GitHub
parent d85c89ba6d
commit df56ab172a
15 changed files with 60 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spec/lib/site_setting_extension_spec.rb
View File

@ -771,7 +771,8 @@ RSpec.describe SiteSettingExtension do
describe '.all_settings' do
describe 'uploads settings' do
it 'should return the right values' do
system_upload = Fabricate(:upload, id: -999)
negative_upload_id = [(Upload.minimum(:id) || 0) - 1, -10].min
system_upload = Fabricate(:upload, id: negative_upload_id)
settings.setting(:logo, system_upload.id, type: :upload)
settings.refresh!
setting = settings.all_settings.last