github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-26 16:34:29 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: prevents global-notice events to leak (#7732)

Browse Source
This commit is contained in:
Joffrey JAFFEUX 2019-06-07 16:49:59 +02:00 committed by GitHub
parent 55325679ac
commit dfb66334c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
app/assets/javascripts/discourse/components/global-notice.js.es6
View File

@ -87,18 +87,36 @@ export default Ember.Component.extend(
@on("didInsertElement") @on("didInsertElement")
_setupLogsNotice() { _setupLogsNotice() {
LogsNotice.current().addObserver("hidden", () => { this._boundRerenderBuffer = Ember.run.bind(this, this.rerenderBuffer);
this.rerenderBuffer(); LogsNotice.current().addObserver("hidden", this._boundRerenderBuffer);
});
this.$().on("click.global-notice", ".alert-logs-notice .close", () => { this._boundResetCurrentProp = Ember.run.bind(
LogsNotice.currentProp("text", ""); this,
}); this._resetCurrentProp
);
$(this.element).on(
"click.global-notice",
".alert-logs-notice .close",
this._boundResetCurrentProp
);
}, },
@on("willDestroyElement") @on("willDestroyElement")
_teardownLogsNotice() { _teardownLogsNotice() {
this.$().off("click.global-notice"); if (this._boundResetCurrentProp) {
$(this.element).off("click.global-notice", this._boundResetCurrentProp);
}
if (this._boundRerenderBuffer) {
LogsNotice.current().removeObserver(
"hidden",
this._boundRerenderBuffer
);
}
},
_resetCurrentProp() {
LogsNotice.currentProp("text", "");
} }
}) })
); );