From e035b07e92c915822f567dee1ef0c64b1959e25d Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Thu, 4 Dec 2014 08:48:25 -0500 Subject: [PATCH] Put Ember 1.8.1 + fixes back. --- app/assets/javascripts/admin.js.erb | 7 - .../discourse/models/category_list.js | 2 +- .../discourse/models/post_stream.js | 2 +- .../javascripts/discourse/templates/topic.hbs | 2 +- .../discourse/views/combo-box.js.es6 | 8 +- .../discourse/views/reply-history.js.es6 | 9 - app/assets/javascripts/main_include_admin.js | 1 + .../stylesheets/common/foundation/base.scss | 3 + app/views/layouts/application.html.erb | 3 + .../javascripts/initializers/poll.js.es6 | 19 +- .../models/post-stream-test.js.es6 | 2 +- .../assets/javascripts/development/ember.js | 12025 +++++++++------- vendor/assets/javascripts/ember-cloaking.js | 58 +- .../{development => }/list-view.js | 238 +- vendor/assets/javascripts/production/ember.js | 11740 ++++++++------- .../javascripts/production/list-view.js | 8 - 16 files changed, 13464 insertions(+), 10663 deletions(-) rename vendor/assets/javascripts/{development => }/list-view.js (91%) delete mode 100755 vendor/assets/javascripts/production/list-view.js diff --git a/app/assets/javascripts/admin.js.erb b/app/assets/javascripts/admin.js.erb index 3c536f4ca65..ce47046a21c 100644 --- a/app/assets/javascripts/admin.js.erb +++ b/app/assets/javascripts/admin.js.erb @@ -1,12 +1,5 @@ <% -if Rails.env.development? - require_asset ("development/list-view.js") -else - require_asset ("production/list-view.js") -end - require_asset("main_include_admin.js") DiscoursePluginRegistry.admin_javascripts.each { |js| require_asset(js) } - %> diff --git a/app/assets/javascripts/discourse/models/category_list.js b/app/assets/javascripts/discourse/models/category_list.js index c0478499d33..ee8b08c1583 100644 --- a/app/assets/javascripts/discourse/models/category_list.js +++ b/app/assets/javascripts/discourse/models/category_list.js @@ -8,7 +8,7 @@ **/ Discourse.CategoryList = Ember.ArrayProxy.extend({ init: function() { - this.content = []; + this.set('content', []); this._super(); } }); diff --git a/app/assets/javascripts/discourse/models/post_stream.js b/app/assets/javascripts/discourse/models/post_stream.js index 026b84e3cf1..583a7939c81 100644 --- a/app/assets/javascripts/discourse/models/post_stream.js +++ b/app/assets/javascripts/discourse/models/post_stream.js @@ -527,7 +527,7 @@ Discourse.PostStream = Em.Object.extend({ this.get('stream').removeObjects(postIds); this.get('posts').removeObjects(posts); postIds.forEach(function(id){ - identityMap.remove(id); + identityMap.delete(id); }); }, diff --git a/app/assets/javascripts/discourse/templates/topic.hbs b/app/assets/javascripts/discourse/templates/topic.hbs index 37feb1da48e..b53bc01ef21 100644 --- a/app/assets/javascripts/discourse/templates/topic.hbs +++ b/app/assets/javascripts/discourse/templates/topic.hbs @@ -73,7 +73,7 @@ {{loading-spinner condition=postStream.loadingAbove}} {{#unless postStream.loadingFilter}} - {{cloaked-collection cloakView="post" + {{cloaked-collection itemViewClass="post" idProperty="post_number" defaultHeight="200" content=postStream.posts diff --git a/app/assets/javascripts/discourse/views/combo-box.js.es6 b/app/assets/javascripts/discourse/views/combo-box.js.es6 index 993bec9514d..fe2381243f8 100644 --- a/app/assets/javascripts/discourse/views/combo-box.js.es6 +++ b/app/assets/javascripts/discourse/views/combo-box.js.es6 @@ -7,7 +7,7 @@ @module Discourse **/ export default Discourse.View.extend({ - tagName: 'select', + tagName: 'span', attributeBindings: ['tabindex'], classNames: ['combobox'], valueAttribute: 'id', @@ -27,6 +27,7 @@ export default Discourse.View.extend({ none = this.get('none'); // Add none option if required + buffer.push(''); }, valueChanged: function() { - var $combo = this.$(), + var $combo = this.$('select'), val = this.get('value'); if (val !== undefined && val !== null) { $combo.val(val.toString()); @@ -64,7 +66,7 @@ export default Discourse.View.extend({ }.observes('content.@each'), didInsertElement: function() { - var $elem = this.$(), + var $elem = this.$('select'), self = this; $elem.select2({formatResult: this.template, minimumResultsForSearch: 5, width: 'resolve'}); diff --git a/app/assets/javascripts/discourse/views/reply-history.js.es6 b/app/assets/javascripts/discourse/views/reply-history.js.es6 index c5f81fa4779..e1f2cb45bc6 100644 --- a/app/assets/javascripts/discourse/views/reply-history.js.es6 +++ b/app/assets/javascripts/discourse/views/reply-history.js.es6 @@ -1,10 +1,3 @@ -/** - Lists previous posts in the history of a post. - - @class ReplyHistory - @namespace Discourse - @module Discourse -**/ export default Em.CollectionView.extend({ tagName: 'section', classNameBindings: [':embedded-posts', ':top', ':topic-body', ':offset2', 'hidden'], @@ -12,5 +5,3 @@ export default Em.CollectionView.extend({ hidden: Em.computed.equal('content.length', 0), previousPost: true }); - - diff --git a/app/assets/javascripts/main_include_admin.js b/app/assets/javascripts/main_include_admin.js index d83be37c142..2cd37f1596c 100644 --- a/app/assets/javascripts/main_include_admin.js +++ b/app/assets/javascripts/main_include_admin.js @@ -1,3 +1,4 @@ +//= require list-view //= require admin/models/user-field //= require admin/controllers/admin-email-skipped //= require admin/controllers/change-site-customization-details diff --git a/app/assets/stylesheets/common/foundation/base.scss b/app/assets/stylesheets/common/foundation/base.scss index 656248df673..1eec1d65dc7 100644 --- a/app/assets/stylesheets/common/foundation/base.scss +++ b/app/assets/stylesheets/common/foundation/base.scss @@ -92,3 +92,6 @@ pre code { .row:after {clear: both;} +#offscreen-content { + display: none; +} diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 931637e8225..111e92e818f 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -61,6 +61,9 @@
+
+
+ <% unless current_user %>