DEV: Stop logging error response body in FileHelper (#17120)

This doesn't cope well with gzipped, binary, or large responses. Ideally we would teach FinalDestination to safely retrieve and decode some of the response body. But for now, let's remove the broken implementation.
This commit is contained in:
David Taylor
2022-06-17 11:50:30 +01:00
committed by GitHub
parent 6695d148d6
commit e0ff367b49
2 changed files with 2 additions and 2 deletions

View File

@ -73,7 +73,7 @@ class FileHelper
# attempt error API compatibility # attempt error API compatibility
io = FakeIO.new io = FakeIO.new
io.status = [response.code, ""] io.status = [response.code, ""]
raise OpenURI::HTTPError.new("#{response.code} Error: #{response.body}", io) raise OpenURI::HTTPError.new("#{response.code} Error", io)
else else
log(:error, "FinalDestination did not work for: #{url}") if verbose log(:error, "FinalDestination did not work for: #{url}") if verbose
throw :done throw :done

View File

@ -29,7 +29,7 @@ describe FileHelper do
expect(e.io.status[0]).to eq("404") expect(e.io.status[0]).to eq("404")
raise raise
end end
end.to raise_error(OpenURI::HTTPError, "404 Error: 404") end.to raise_error(OpenURI::HTTPError, "404 Error")
end end
it "does not follow redirects if instructed not to" do it "does not follow redirects if instructed not to" do