mirror of
https://github.com/discourse/discourse.git
synced 2025-05-21 18:12:32 +08:00
DEV: Add a new way to run specs in parallel with better output (#7778)
* DEV: Add a new way to run specs in parallel with better output This commit: 1. adds a new executable, `bin/interleaved_rspec` which works much like `rspec`, but runs the tests in parallel. 2. adds a rake task, `rake interleaved:spec` which runs the whole test suite. 3. makes autospec use this new wrapper by default. You can disable this by running `PARALLEL_SPEC=0 rake autospec`. It works much like the `parallel_tests` gem (and relies on it), but makes each subprocess use a machine-readable formatter and parses this output in order to provide a better overall summary. (It's called interleaved, because parallel was taken and naming is hard). * Make popen3 invocation safer * Use FileUtils instead of shelling out * DRY up reporter * Moved summary logic into Reporter * s/interleaved/turbo/g * Move Reporter into its own file * Moved run into its own class * Moved Runner into its own file * Move JsonRowsFormatter under TurboTests * Join on threads at the end * Acted on feedback from eviltrout
This commit is contained in:
134
lib/turbo_tests/runner.rb
Normal file
134
lib/turbo_tests/runner.rb
Normal file
@ -0,0 +1,134 @@
|
||||
module TurboTests
|
||||
class Runner
|
||||
def self.run(formatter_config, files, start_time=Time.now)
|
||||
reporter = Reporter.from_config(formatter_config, start_time)
|
||||
|
||||
new(reporter, files).run
|
||||
end
|
||||
|
||||
def initialize(reporter, files)
|
||||
@reporter = reporter
|
||||
@files = files
|
||||
@messages = Queue.new
|
||||
@threads = []
|
||||
end
|
||||
|
||||
def run
|
||||
@num_processes = ParallelTests.determine_number_of_processes(nil)
|
||||
|
||||
tests_in_groups =
|
||||
ParallelTests::RSpec::Runner.tests_in_groups(
|
||||
@files,
|
||||
@num_processes,
|
||||
group_by: :filesize
|
||||
)
|
||||
|
||||
setup_tmp_dir
|
||||
|
||||
tests_in_groups.each_with_index do |tests, process_num|
|
||||
start_subprocess(tests, process_num + 1)
|
||||
end
|
||||
|
||||
handle_messages
|
||||
|
||||
@reporter.finish
|
||||
|
||||
@threads.each(&:join)
|
||||
end
|
||||
|
||||
protected
|
||||
|
||||
def setup_tmp_dir
|
||||
begin
|
||||
FileUtils.rm_r('tmp/test-pipes')
|
||||
rescue Errno::ENOENT
|
||||
end
|
||||
|
||||
FileUtils.mkdir_p('tmp/test-pipes/')
|
||||
end
|
||||
|
||||
def start_subprocess(tests, process_num)
|
||||
if tests.empty?
|
||||
@messages << {type: 'exit', process_num: process_num}
|
||||
else
|
||||
begin
|
||||
File.mkfifo("tmp/test-pipes/subprocess-#{process_num}")
|
||||
rescue Errno::EEXIST
|
||||
end
|
||||
|
||||
stdin, stdout, stderr, wait_thr =
|
||||
Open3.popen3(
|
||||
{'TEST_ENV_NUMBER' => process_num.to_s},
|
||||
"bundle", "exec", "rspec",
|
||||
"-f", "TurboTests::JsonRowsFormatter",
|
||||
"-o", "tmp/test-pipes/subprocess-#{process_num}",
|
||||
*tests
|
||||
)
|
||||
|
||||
@threads <<
|
||||
Thread.new do
|
||||
File.open("tmp/test-pipes/subprocess-#{process_num}") do |fd|
|
||||
fd.each_line do |line|
|
||||
message = JSON.parse(line)
|
||||
message = message.symbolize_keys
|
||||
message[:process_num] = process_num
|
||||
@messages << message
|
||||
end
|
||||
end
|
||||
|
||||
@messages << {type: 'exit', process_num: process_num}
|
||||
end
|
||||
|
||||
@threads << start_copy_thread(stdout, STDOUT)
|
||||
@threads << start_copy_thread(stderr, STDERR)
|
||||
end
|
||||
end
|
||||
|
||||
def start_copy_thread(src, dst)
|
||||
Thread.new do
|
||||
while true
|
||||
begin
|
||||
msg = src.readpartial(4096)
|
||||
rescue EOFError
|
||||
break
|
||||
else
|
||||
dst.write(msg)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
def handle_messages
|
||||
exited = 0
|
||||
|
||||
begin
|
||||
while true
|
||||
message = @messages.pop
|
||||
case message[:type]
|
||||
when 'example_passed'
|
||||
example = FakeExample.from_obj(message[:example])
|
||||
@reporter.example_passed(example)
|
||||
when 'example_pending'
|
||||
example = FakeExample.from_obj(message[:example])
|
||||
@reporter.example_pending(example)
|
||||
when 'example_failed'
|
||||
example = FakeExample.from_obj(message[:example])
|
||||
@reporter.example_failed(example)
|
||||
when 'seed'
|
||||
when 'close'
|
||||
when 'exit'
|
||||
exited += 1
|
||||
if exited == @num_processes
|
||||
break
|
||||
end
|
||||
else
|
||||
STDERR.puts("Unhandled message in main process: #{message}")
|
||||
end
|
||||
|
||||
STDOUT.flush
|
||||
end
|
||||
rescue Interrupt
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
Reference in New Issue
Block a user