github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 04:08:14 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Add polymorphic bookmarkable columns (#15454)

Browse Source 
We are planning on attaching bookmarks to more and
more other models, so it makes sense to make a polymorphic
relationship to handle this. This commit adds the new
columns and backfills them in the bookmark table, and
makes sure that any new bookmark changes fill in the columns
via DB triggers.

This way we can gradually change the frontend and backend
to use these new columns, and eventually delete the
old post_id and for_topic columns in `bookmarks`.
This commit is contained in:
Martin Brennan
2022-01-06 08:56:05 +10:00
committed by GitHub
parent e6ab8f5b71
commit e21c640a3c
6 changed files with 80 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/models/topic.rb
View File

@ -203,7 +203,15 @@ class Topic < ActiveRecord::Base
belongs_to :category
has_many :category_users, through: :category
has_many :posts
# When we are ready we can add as: :bookmarkable here to use the
# polymorphic association.
#
# At that time we may also want to make another association for example
# :topic_bookmarks that get all of the bookmarks for that topic's bookmarkable id
# and type, because this one gets all of the post bookmarks.
has_many :bookmarks, through: :posts
has_many :ordered_posts, -> { order(post_number: :asc) }, class_name: "Post"
has_many :topic_allowed_users
has_many :topic_allowed_groups