github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 02:38:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Don't user before(:all)/after(:all) (#13389)

Browse Source 
Leaking state and non-obvious order (before :all runs *before* RailsHelper.test_setup) are not worth it.
A replacement PR for #13370. Fixes some flaky specs, e.g.
```
bin/rspec './spec/components/freedom_patches/translate_accelerator_spec.rb[1:3]' './spec/jobs/clean_up_user_export_topics_spec.rb[1:1]' --tag ~type:multisite --seed 35994
```

Also included:
* DEV: No need for locale reset (we do it anyway in rails_helper in `test_setup`)
This commit is contained in:
Jarek Radosz
2021-06-15 17:25:06 +02:00
committed by GitHub
parent bfeaf75cd5
commit e36377d9ab
9 changed files with 17 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spec/models/theme_spec.rb
View File

@ -7,10 +7,6 @@ describe Theme do
Theme.clear_cache!
end
before do
I18n.locale = :en
end
fab! :user do
Fabricate(:user)
end
@ -21,6 +17,7 @@ describe Theme do
let(:theme) { Fabricate(:theme, user: user) }
let(:child) { Fabricate(:theme, user: user, component: true) }
it 'can properly clean up color schemes' do
scheme = ColorScheme.create!(theme_id: theme.id, name: 'test')
scheme2 = ColorScheme.create!(theme_id: theme.id, name: 'test2')