Fix onebox loading on every keystroke after a request fails.

spec/controllers/onebox_controller_spec.rb

@@ -2,14 +2,46 @@ require 'spec_helper'
 
 describe OneboxController do
 
-  it 'asks the oneboxer for the preview' do
-    Oneboxer.expects(:preview).with('http://google.com')
-    xhr :get, :show, url: 'http://google.com'
-  end
+  let(:url) { "http://google.com" }
 
   it 'invalidates the cache if refresh is passed' do
-    Oneboxer.expects(:invalidate).with('http://google.com')
-    xhr :get, :show, url: 'http://google.com', refresh: true
+    Oneboxer.expects(:invalidate).with(url)
+    xhr :get, :show, url: url, refresh: true
+  end
+
+  describe "found onebox" do
+
+    let(:body) { "this is the onebox body"}
+
+    before do
+      Oneboxer.expects(:preview).with(url).returns(body)
+      xhr :get, :show, url: url
+    end
+
+    it 'returns success' do
+      response.should be_success
+    end
+
+    it 'returns the onebox response in the body' do
+      response.body.should == body
+    end
+
+  end
+
+  describe "missing onebox" do
+
+    it "returns 404 if the onebox is nil" do
+      Oneboxer.expects(:preview).with(url).returns(nil)
+      xhr :get, :show, url: url
+      response.response_code.should == 404
+    end
+
+    it "returns 404 if the onebox is an empty string" do
+      Oneboxer.expects(:preview).with(url).returns(" \t ")
+      xhr :get, :show, url: url
+      response.response_code.should == 404
+    end
+
   end
 
 end