From e5a13b0ac1eca6aab6548347308d2f611e3ab3fd Mon Sep 17 00:00:00 2001 From: Arpit Jalan Date: Tue, 18 Oct 2016 00:30:29 +0530 Subject: [PATCH] FIX: specify CSV file encoding and better error reporting --- app/jobs/regular/bulk_invite.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/jobs/regular/bulk_invite.rb b/app/jobs/regular/bulk_invite.rb index 835ac0e6c75..44b14abe642 100644 --- a/app/jobs/regular/bulk_invite.rb +++ b/app/jobs/regular/bulk_invite.rb @@ -29,6 +29,7 @@ module Jobs # read csv file, and send out invitations read_csv_file(csv_path) + ensure # send notification to user regarding progress notify_user @@ -48,7 +49,7 @@ module Jobs end def read_csv_file(csv_path) - CSV.foreach(csv_path) do |csv_info| + CSV.foreach(csv_path, encoding: "iso-8859-1:UTF-8") do |csv_info| if csv_info[0] if (EmailValidator.email_regex =~ csv_info[0]) # email is valid @@ -61,6 +62,9 @@ module Jobs end end end + rescue Exception => e + log "Bulk Invite Process Failed -- '#{e.message}'" + @failed += 1 end def get_group_ids(group_names, csv_line_number)