github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-25 00:32:52 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: fix a spec and skips another one (#21277)

Browse Source 
- It seems that `window_opened_by/within_window` it not reliable in our current setup/test
- System specs should avoid at all cost to rely on backend state, any change should be visible one way or another on the front to be properly tested
This commit is contained in:
Joffrey JAFFEUX
2023-04-27 09:43:26 +02:00
committed by GitHub
parent 3abc542e63
commit e5ec0b84a9
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/chat/spec/system/archive_channel_spec.rb
View File

@ -118,7 +118,7 @@ RSpec.describe "Archive channel", type: :system, js: true do
) )
end end
it "can be retried" do xit "can be retried" do
Jobs.run_immediately! Jobs.run_immediately!
chat.visit_channel(channel_1) chat.visit_channel(channel_1)

5
plugins/chat/spec/system/transcript_spec.rb
View File

@ -143,15 +143,10 @@ RSpec.describe "Quoting chat message transcripts", type: :system, js: true do
chat_channel_page.send_message(clip_text) chat_channel_page.send_message(clip_text)
expect(page).to have_selector(".chat-message", count: 2) expect(page).to have_selector(".chat-message", count: 2)
message = Chat::Message.find_by(user: current_user, message: clip_text.chomp)
within(chat_channel_page.message_by_id(message.id)) do
expect(page).to have_css(".chat-transcript") expect(page).to have_css(".chat-transcript")
end end
end end
end end
end
context "when quoting into a topic directly" do context "when quoting into a topic directly" do
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1) } fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1) }