From e605542c4e1ee8f67dffd06e7422cc17c83c243e Mon Sep 17 00:00:00 2001
From: Sam <sam.saffron@gmail.com>
Date: Wed, 24 Oct 2018 11:53:28 +1100
Subject: [PATCH] PERF: limit unread count to 99 in the blue circle

This safeguard is in place to avoid very expensive queries on the server
side
---
 app/models/user.rb | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/app/models/user.rb b/app/models/user.rb
index 06b6ba89b67..b7925553aa4 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -434,24 +434,31 @@ class User < ActiveRecord::Base
     @unread_pms ||= unread_notifications_of_type(Notification.types[:private_message])
   end
 
+  # PERF: This safeguard is in place to avoid situations where
+  # a user with enormous amounts of unread data can issue extremely
+  # expensive queries
+  MAX_UNREAD_NOTIFICATIONS = 99
+
   def unread_notifications
     @unread_notifications ||= begin
       # perf critical, much more efficient than AR
       sql = <<~SQL
-          SELECT COUNT(*)
-            FROM notifications n
-       LEFT JOIN topics t ON t.id = n.topic_id
-           WHERE t.deleted_at IS NULL
-             AND n.notification_type <> :pm
-             AND n.user_id = :user_id
-             AND n.id > :seen_notification_id
-             AND NOT read
+        SELECT COUNT(*) FROM notifications n
+        LEFT JOIN topics t ON t.id = n.topic_id
+         WHERE t.deleted_at IS NULL AND
+          n.notification_type <> :pm AND
+          n.user_id = :user_id AND
+          n.id > :seen_notification_id AND
+          NOT read
+        LIMIT :limit
+
       SQL
 
       DB.query_single(sql,
         user_id: id,
         seen_notification_id: seen_notification_id,
-        pm:  Notification.types[:private_message]
+        pm:  Notification.types[:private_message],
+        limit: MAX_UNREAD_NOTIFICATIONS
     )[0].to_i
     end
   end