mirror of
https://github.com/discourse/discourse.git
synced 2025-05-23 23:31:18 +08:00
FIX: never redirect back to /sso
it will cause a loop
If for any reason our return url is set to `/sso` bypass using it for login redirect
This commit is contained in:
@ -303,6 +303,16 @@ RSpec.describe SessionController do
|
||||
|
||||
end
|
||||
|
||||
it 'will never redirect back to /sso path' do
|
||||
sso = get_sso("/sso?bla=1")
|
||||
sso.email = user.email
|
||||
sso.external_id = 'abc'
|
||||
sso.username = 'sam'
|
||||
|
||||
get "/session/sso_login", params: Rack::Utils.parse_query(sso.payload), headers: headers
|
||||
expect(response).to redirect_to('/')
|
||||
end
|
||||
|
||||
it 'can take over an account' do
|
||||
sso = get_sso("/")
|
||||
user = Fabricate(:user)
|
||||
|
Reference in New Issue
Block a user