github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 15:28:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

REFACTOR: Replace score bonuses with low/med/high priorities

Browse Source 
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
This commit is contained in:
Robin Ward
2019-05-22 17:23:45 -04:00
parent 30961dd875
commit e74cd54fc6
21 changed files with 142 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spec/models/reviewable_spec.rb
View File

@ -284,20 +284,20 @@ RSpec.describe Reviewable, type: :model do
context "priorities" do
it "returns 0 for unknown priorities" do
expect(Reviewable.min_score_for_priority('wat')).to eq(0.0)
expect(Reviewable.min_score_for_priority(:wat)).to eq(0.0)
end
it "returns 0 for all by default" do
expect(Reviewable.min_score_for_priority('low')).to eq(0.0)
expect(Reviewable.min_score_for_priority('medium')).to eq(0.0)
expect(Reviewable.min_score_for_priority('high')).to eq(0.0)
expect(Reviewable.min_score_for_priority(:low)).to eq(0.0)
expect(Reviewable.min_score_for_priority(:medium)).to eq(0.0)
expect(Reviewable.min_score_for_priority(:high)).to eq(0.0)
end
it "can be set manually with `set_priorities`" do
Reviewable.set_priorities(medium: 12.5, high: 123.45)
expect(Reviewable.min_score_for_priority('low')).to eq(0.0)
expect(Reviewable.min_score_for_priority('medium')).to eq(12.5)
expect(Reviewable.min_score_for_priority('high')).to eq(123.45)
expect(Reviewable.min_score_for_priority(:low)).to eq(0.0)
expect(Reviewable.min_score_for_priority(:medium)).to eq(12.5)
expect(Reviewable.min_score_for_priority(:high)).to eq(123.45)
end
it "will return the default priority if none supplied" do