github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 22:43:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix SiteSetingExtension specs to coerce int to string.

Browse Source
This commit is contained in:
Guo Xiang Tan
2017-07-24 22:54:42 +09:00
parent 0ab0c82f11
commit e82efc7b03
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/site_setting_extension.rb
View File

@ -284,6 +284,8 @@ module SiteSettingExtension
def add_override!(name, val) def add_override!(name, val)
type = get_data_type(name, defaults[name.to_sym]) type = get_data_type(name, defaults[name.to_sym])
val = val.to_s if type == types[:string]
if type == types[:bool] && val != true && val != false if type == types[:bool] && val != true && val != false
val = (val == "t" || val == "true") ? 't' : 'f' val = (val == "t" || val == "true") ? 't' : 'f'
end end

1
spec/components/site_setting_extension_spec.rb
View File

@ -179,7 +179,6 @@ describe SiteSettingExtension do
end end
it "should coerce int to string" do it "should coerce int to string" do
skip "This test is not working on Rspec 2 even"
settings.test_str = 100 settings.test_str = 100
expect(settings.test_str).to eq("100") expect(settings.test_str).to eq("100")
end end